Skip to content
Build and Test SynchWeb

Merge pull request #691 from DiamondLightSource/improve/make_php_lint… #470

Sign in to view logs

Merge pull request #691 from DiamondLightSource/improve/make_php_lint…

Merge pull request #691 from DiamondLightSource/improve/make_php_lint… #470

Triggered via push November 2, 2023 17:16
@John-Holt-TessellaJohn-Holt-Tessella
pushed c82aac0
prerelease
Status Success
Total duration 2m 4s
Artifacts –

ci.yml

on: push
Checkout, build, test and lint PHP code
1m 51s
Checkout, build, test and lint PHP code
JavaScript build, test and lint
1m 42s
JavaScript build, test and lint
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 9 warnings
JavaScript build, test and lint: client/src/js/models/protein.js#L19
Do not access attributes directly. Use set() and get() instead
JavaScript build, test and lint: client/src/js/models/visit.js#L54
Do not access attributes directly. Use set() and get() instead
JavaScript build, test and lint: client/src/js/models/visit.js#L55
Do not access attributes directly. Use set() and get() instead
JavaScript build, test and lint: client/src/js/models/visit.js#L56
Do not access attributes directly. Use set() and get() instead
JavaScript build, test and lint: client/src/js/models/visit.js#L56
Do not access attributes directly. Use set() and get() instead
JavaScript build, test and lint: client/src/js/models/visit.js#L56
Do not access attributes directly. Use set() and get() instead
JavaScript build, test and lint: client/src/js/models/visit.js#L57
Do not access attributes directly. Use set() and get() instead
JavaScript build, test and lint: client/src/js/modules/cell/views/beamlines.js#L45
Move function declaration to function body root
JavaScript build, test and lint: client/src/js/modules/dc/models/autointegration.js#L16
Do not access attributes directly. Use set() and get() instead
JavaScript build, test and lint: client/src/js/modules/dc/models/autointegration.js#L19
Do not access attributes directly. Use set() and get() instead
JavaScript build, test and lint: client/src/js/modules/dc/views/queuebuilder.js#L27
Do not silence events
JavaScript build, test and lint: client/src/js/modules/dc/views/queuebuilder.js#L28
Do not silence events
JavaScript build, test and lint: client/src/js/modules/dc/views/queuebuilder.js#L158
Do not silence events
JavaScript build, test and lint: client/src/js/modules/shipment/collections/platetypes.js#L139
Do not silence events
JavaScript build, test and lint: client/src/js/views/search.js#L169
Use this.$ instead of $ in views
JavaScript build, test and lint: client/src/js/views/search.js#L170
Use this.$ instead of $ in views
JavaScript build, test and lint: client/src/js/views/search.js#L172
Use this.$ instead of $ in views
JavaScript build, test and lint: client/src/js/views/search.js#L185
Use this.$ instead of $ in views
JavaScript build, test and lint: client/src/js/views/search.js#L186
Use this.$ instead of $ in views