Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added velocity support #641

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Added velocity support #641

wants to merge 6 commits into from

Conversation

KikyoC
Copy link

@KikyoC KikyoC commented May 13, 2024

Hello,
I added velocity support and I tested it and it looks working. I checked that the /unban bug (because of not cached) is fixed.

@Hopefuls
Copy link
Collaborator

are the changes based off of the development branch?

@KikyoC
Copy link
Author

KikyoC commented Jun 22, 2024

Nope I don't think, you can see here that I'm up to date with leoko dev branch here: https://github.com/KikyoC/AdvancedBan/tree/master

@Bensonheimer992
Copy link

Hey every time i ban someone with the Velocity Version of AdvancedBan i have to restart the proxy to unban them if i don't restart the proxy i get the message that this player is not banned

@Hopefuls
Copy link
Collaborator

Hey every time i ban someone with the Velocity Version of AdvancedBan i have to restart the proxy to unban them if i don't restart the proxy i get the message that this player is not banned

is this related to this pull request? if no then that is known.

@KikyoC
Copy link
Author

KikyoC commented Jun 30, 2024

Hey every time i ban someone with the Velocity Version of AdvancedBan i have to restart the proxy to unban them if i don't restart the proxy i get the message that this player is not banned

Hello, check this one, I'm waiting they response to open a second pr (because I did something stupid): https://github.com/Swordfun-Server/AdvancedBan

@Bensonheimer992
Copy link

Hey every time i ban someone with the Velocity Version of AdvancedBan i have to restart the proxy to unban them if i don't restart the proxy i get the message that this player is not banned

Hello, check this one, I'm waiting they response to open a second pr (because I did something stupid): https://github.com/Swordfun-Server/AdvancedBan

this version does not work either it still says after banning this player is not banned

@KikyoC
Copy link
Author

KikyoC commented Jun 30, 2024

Hey every time i ban someone with the Velocity Version of AdvancedBan i have to restart the proxy to unban them if i don't restart the proxy i get the message that this player is not banned

Hello, check this one, I'm waiting they response to open a second pr (because I did something stupid): https://github.com/Swordfun-Server/AdvancedBan

this version does not work either it still says after banning this player is not banned

I don't have this issue. i'm checking it

@KikyoC
Copy link
Author

KikyoC commented Jun 30, 2024

Hey every time i ban someone with the Velocity Version of AdvancedBan i have to restart the proxy to unban them if i don't restart the proxy i get the message that this player is not banned

Hello, check this one, I'm waiting they response to open a second pr (because I did something stupid): https://github.com/Swordfun-Server/AdvancedBan

this version does not work either it still says after banning this player is not banned

I missed something. Should now work (with new release)

@Bensonheimer992
Copy link

can i still use the normal advancedban api or do i have to do something special for it to work with the velocity version ?

@Bensonheimer992
Copy link

can i still use the normal advancedban api or do i have to do something special for it to work with the velocity version ?

because im trying to use the PunishEvent and nothing happens (i checked that the event is registered)

@Bensonheimer992
Copy link

Hey every time i ban someone with the Velocity Version of AdvancedBan i have to restart the proxy to unban them if i don't restart the proxy i get the message that this player is not banned

Hello, check this one, I'm waiting they response to open a second pr (because I did something stupid): https://github.com/Swordfun-Server/AdvancedBan

this version does not work either it still says after banning this player is not banned

I missed something. Should now work (with new release)

?

@KikyoC
Copy link
Author

KikyoC commented Jul 7, 2024

Hello, I havent edited anything from the api.

@Bensonheimer992
Copy link

but the event does not get triggered

@Bensonheimer992
Copy link

Hello, I havent edited anything from the api.

and maybe change the server type from BungeeCord to Velocity

@DevLeoko
Copy link
Owner

Thanks for your effort to support velocity @KikyoC
Are the changes from this PR tested and stable? Because you mentioned newer changes and a second PR above.

@KikyoC
Copy link
Author

KikyoC commented Sep 1, 2024

Hey everyone !

I'm sorry if I don't answered on time. I get to many things in my life so that's why I'm answering late.

As I said I did something better on https://github.com/Swordfun-Server/AdvancedBan but I meged everything in this repo. I just tried and everything looks good.

@nhanledev
Copy link

Hello, I just tested the Velocity support by building https://github.com/Swordfun-Server/AdvancedBan and run it on my server (velocity only)

  • mute, tempmute: OK, player can not send message after being muted
  • ban, tempban: OK, player is kicked and can not join the server after being banned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants