FullHistory #623
Merged
FullHistory #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
took a more configurable way for DevLeoko#427 where you can exclude any punishment type if you so choose
DevLeoko
requested changes
Jul 4, 2023
These are changes based on the comments of the pull request
Added a lime to conform to style, and adjusted the javadoc
|
That makes sense, I made the changes based on what I interpreted of what you said. |
I condensed the new method i added wouldnt let me add the ternary operator in the getpunishments And i got rid of the temp variable because I didn't like it
DevLeoko
requested changes
Jul 4, 2023
core/src/main/java/me/leoko/advancedban/manager/PunishmentManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/me/leoko/advancedban/manager/PunishmentManager.java
Outdated
Show resolved
Hide resolved
|
Feel free to also message me on Discord if you have questions or want to chat about the comments. |
These are the asked changes, however it cannot stay this way because ambiguous callls
Removing ambiguous calls
DevLeoko
requested changes
Jul 4, 2023
Comment on lines
301
to
304
| if (!Universal.get().hasPerms(input.getSender(), "ab.history")) { | ||
| MessageManager.sendMessage(input.getSender(), "General.NoPerms", true); | ||
| return; | ||
| } |
There was a problem hiding this comment.
I don't think that you need to perform a permission check here as the permission for the command is specified a few lines above
Didnt see the previous perm check
DevLeoko
approved these changes
Jul 5, 2023
|
Thanks for adding this feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
took a more configurable way for #427 where you can exclude any punishment type if you so choose