Skip to content
This repository has been archived by the owner on Nov 7, 2024. It is now read-only.

Update to nushell 0.87.1 #20

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Conversation

NotLebedev
Copy link
Contributor

@NotLebedev NotLebedev commented Dec 1, 2023

Great project! Learned quite a bit about nix from it and the talk. Updated this to latest (at the moment) version of nushell to make it more useful to anybody interested and myself.
Changes:

  • Switched nixpkgs flake input to github:NixOS/nixpkgs/nixos-unstable (clould not figure out how to do it via flakehub)
  • Replaced usages of let-env as it is deprecated now.
  • Replaced source with use as it is not really necessary
  • Added missing -f option when copying sources
  • Fixed use of format date in example
  • Fixed logging inside phases (build phase). Since this PR nushell no longer prints output of each commands automatically like bash does. Instead it behaves like conventional programming languages (like python in interpreter mode). It prints return value of last operation in repl mode only and anything explicitly printed via print command

Copy link
Member

@lucperkins lucperkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot! 💯

@lucperkins lucperkins merged commit cbc3cc7 into DeterminateSystems:main Dec 6, 2023
3 checks passed
@grahamc grahamc mentioned this pull request Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants