Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fish support on ostree #711

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix fish support on ostree #711

wants to merge 4 commits into from

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Nov 8, 2023

Description

Closes #707

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

src/planner/ostree.rs Outdated Show resolved Hide resolved
@Hoverbear Hoverbear added this to the 0.14.1 milestone Nov 8, 2023
@Hoverbear Hoverbear added the upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing label Nov 8, 2023
src/planner/ostree.rs Show resolved Hide resolved
src/planner/ostree.rs Show resolved Hide resolved
@grahamc
Copy link
Member Author

grahamc commented Nov 9, 2023

Unfortunately this doesn't work: the plan says to create the directory, then the planning phase detects the directory doesn't exist (yet) and decides to not install it. Hrm.

@Hoverbear
Copy link
Contributor

I believe that is because of

if !fish_prefix_path.exists() {
// If the prefix doesn't exist, don't create the `conf.d/nix.fish`
continue;
}

Perhaps that should happen at execute time.

@Hoverbear Hoverbear modified the milestones: 0.15.0, 0.15.1 Nov 14, 2023
@cole-h
Copy link
Member

cole-h commented Dec 5, 2023

Marking this as a draft based on this previous comment: #711 (comment).

@cole-h cole-h marked this pull request as draft December 5, 2023 19:21
@Hoverbear Hoverbear removed this from the 0.15.2 milestone Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selftest failures on ostree + fish
3 participants