Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigureInitService: remove dest files on revert (if they exist) #1266

Merged
merged 1 commit into from
Oct 31, 2024
Merged

ConfigureInitService: remove dest files on revert (if they exist) #1266

merged 1 commit into from
Oct 31, 2024

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Oct 31, 2024 •
edited
Loading

Description

Builds on top of #1257.
Closes #989.

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@cole-h cole-h mentioned this pull request Oct 31, 2024
Closed
@cole-h cole-h force-pushed the configure-init-remove-dest-files branch from e13043a to 1d85c91 Compare October 31, 2024 16:01
Base automatically changed from fix-bootout-failures to main October 31, 2024 16:02
@cole-h cole-h force-pushed the configure-init-remove-dest-files branch from 1d85c91 to 6ad46f6 Compare October 31, 2024 16:03
@cole-h cole-h marked this pull request as ready for review October 31, 2024 16:03
grahamc
grahamc approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, nice cleanup

@cole-h cole-h merged commit 7fcb69b into main Oct 31, 2024
21 checks passed
@cole-h cole-h deleted the configure-init-remove-dest-files branch October 31, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uninstaller: rolling back nix launchd services currently is not best-effort
2 participants
@cole-h @grahamc