Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the assertion around the netrc under dnixd #103

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Sep 17, 2024

As it stands, determinate + magic-nix-cache seems universally disabled, because the netrc path is being specified. After #102 not sure where this leaves it.

Not sure the implications of this, but let's try this.

@colemickens
Copy link
Member

colemickens commented Sep 17, 2024

Oh I'm so sorry to do this to you, but also, it's good timing, because now the right choice is more obvious.

So, the issue is that we /still use/ the user specified netrc path to read the FH password. And if they tell us the wrong path, we won't be able to load the right password and init the flakehub cache anyway.

So after just telling you this is fine, I think it's not fine, and I think the best solution is to make magic-nix-cache read your new auth token you just merged, and remove this netrc parsing entirely. Or something step-wisey to get approximately there?

@grahamc grahamc merged commit 7c6bd93 into main Sep 17, 2024
14 of 15 checks passed
@grahamc grahamc deleted the fh-cache-under-determinate branch September 17, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants