Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing input deps is a println!, not fatal error #125

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

colemickens
Copy link
Member

Some flakes don't have nixpkgs, be a bit more accepting of them.

@lucperkins
Copy link
Member

lucperkins commented Jun 21, 2024

@colemickens The tool does currently enable you to supply a specific set of Nixpkgs keys via --nixpkgs-keys. I'd prefer to keep the current behavior.

@colemickens
Copy link
Member Author

colemickens commented Jun 21, 2024

@lucperkins for context, this is for testing with DeterminateSystems/ci.

Not having this would imply needing another option for ci to teach it about what branches to check. I'd be curious for @grahamc's thoughts on that.

@colemickens colemickens force-pushed the colemickens/allow-no-nixpkgs-input branch from 1d663bb to 781d35b Compare June 21, 2024 23:02
@colemickens
Copy link
Member Author

For now, I can probably set NIX_FLAKE_CHECKER_NIXPKGS_KEYS for my parent workflow...

@lucperkins
Copy link
Member

The issue is that there's always an expected set of Nixpkgs input keys. The default is ["nixpkgs"] but you can override that. With the behavior proposed in this PR, Flake Checker would simply successfully exit if none of the provided keys actually were Nixpkgs inputs, which would be surprising behavior, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants