recordEvent isn't need async

DeterminateSystems · Mar 15, 2024 · f72fbb0 · f72fbb0
1 parent e53cf29
commit f72fbb0
Show file tree

Hide file tree

Showing 3 changed files with 48 additions and 14 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/src/main.ts b/src/main.ts
@@ -170,7 +170,7 @@ export class IdsToolbox {
 
     {
       const phase = actions_core.getState("idstoolbox_execution_phase");
-      if (phase == "") {
+      if (phase === "") {
         actions_core.saveState("idstoolbox_execution_phase", "post");
         this.executionPhase = "action";
       } else {
@@ -249,11 +249,11 @@ export class IdsToolbox {
           true,
         )
       ) {
-        await this.recordEvent("artifact_cache_hit");
+        this.recordEvent("artifact_cache_hit");
         return `${tempDir}/${this.options.name}`;
       }
 
-      await this.recordEvent("artifact_cache_miss");
+      this.recordEvent("artifact_cache_miss");
       return undefined;
     } finally {
       process.env.GITHUB_WORKSPACE = process.env.GITHUB_WORKSPACE_BACKUP;
@@ -284,18 +284,15 @@ export class IdsToolbox {
         undefined,
         true,
       );
-      await this.recordEvent("artifact_cache_hit");
+      this.recordEvent("artifact_cache_hit");
     } finally {
       process.env.GITHUB_WORKSPACE = process.env.GITHUB_WORKSPACE_BACKUP;
       delete process.env.GITHUB_WORKSPACE_BACKUP;
       process.chdir(startCwd);
     }
   }
 
-  async recordEvent(
-    event_name: string,
-    context: Record<string, unknown> = {},
-  ): Promise<void> {
+  recordEvent(event_name: string, context: Record<string, unknown> = {}): void {
     this.events.push({
       event_name: `${this.options.eventPrefix}${event_name}`,
       context,

diff --git a/src/test-run.ts b/src/test-run.ts
@@ -1,3 +1,6 @@
+// eslint-disable-next-line import/no-unresolved
+import { IdsToolbox } from "./main.js";
+
 process.env["RUNNER_ARCH"] = "ARM64";
 process.env["RUNNER_OS"] = "macOS";
 process.env["IDS_HOST"] = "http://localhost:8080";
@@ -11,8 +14,6 @@ process.env["GITHUB_RUN_ID"] = "58";
 process.env["GITHUB_RUN_NUMBER"] = "78";
 process.env["GITHUB_RUN_ATTEMPT"] = "1";
 
-import { IdsToolbox } from "./main.js";
-
 async function main(): Promise<void> {
   {
     const toolbox = new IdsToolbox({