Skip to content

Commit

Permalink
Move the backtrace collection handler to be unconditionally, right be…
Browse files Browse the repository at this point in the history
…fore we complete
  • Loading branch information
grahamc committed Aug 23, 2024
1 parent fe32be8 commit ef360e9
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
4 changes: 3 additions & 1 deletion dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map

Large diffs are not rendered by default.

6 changes: 4 additions & 2 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -398,8 +398,6 @@ export abstract class DetSysAction {
await this.main();
} else if (this.isPost) {
await this.post();

await this.collectBacktraces();
}
this.addFact(FACT_ENDED_WITH_EXCEPTION, false);
} catch (e: unknown) {
Expand Down Expand Up @@ -436,6 +434,10 @@ export abstract class DetSysAction {

this.recordEvent(EVENT_EXCEPTION, Object.fromEntries(exceptionContext));
} finally {
if (this.isPost) {
await this.collectBacktraces();
}

await this.complete();
}
}
Expand Down

0 comments on commit ef360e9

Please sign in to comment.