Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential race condition in PolicyEngineTest#notificationTest #4203

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Oct 1, 2024

Description

Fixes potential race condition in PolicyEngineTest#notificationTest.

Since notification dispatch happens asynchronously, it's possible that the assertion happens before the notification is received. Await notifications with a small timeout instead.

Addressed Issue

N/A

Additional Details

Example test failure: https://github.com/DependencyTrack/dependency-track/actions/runs/11124919968/job/30911500389#step:4:486

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Since notification dispatch happens asynchronously, it's possible that the assertion happens before the notification is received. Await notifications with a small timeout instead.

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro added this to the 4.12 milestone Oct 1, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 56d9deb1 (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (56d9deb) Report Missing Report Missing Report Missing
Head commit (b4ec664) 22436 17743 79.08%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4203) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@nscuro nscuro merged commit bf96849 into DependencyTrack:master Oct 1, 2024
10 checks passed
@nscuro nscuro deleted the fix-test-flakiness branch October 1, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant