Fix version distance policy being evaluated despite not being configured #2980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also handle failures in computing the version distance. Fixes DependencyTrack#2979 Signed-off-by: nscuro <[email protected]>
…ion is configured Do not perform any expensive or potentially failing computation unless the policy *actually* has to be evaluated. Signed-off-by: nscuro <[email protected]>
leec94
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
i was unable to run a test by “specifying a non-numerical value for the “epoch”", looks like only numbers are allowed.
but i ran a second test, so I added a component with invalid version and i didn’t get any output, which is expected.
looks like this version distance policy is only being run when specified now. good work, approved
|
Thanks @leec94! I'll try to make it a habit to include "how to test" instructions in the PR description. 😁 |
|
a "how to test" section would be really helpful! thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a defect where the new version distance policy was being evaluated despite not being configured by users.
This PR additionally adds checks to policy evaluators that ensure that no expensive or potentially failing computation is being performed, unless the policy actually needs to be verified. This was previously not always the case, causing unnecessary database queries to be performed etc.
Addressed Issue
Fixes #2979
Additional Details
N/A
Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have added corresponding update logicThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly