Add extra edge cases to snap to grid #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
* Node index != line index; every N segments has N + 1 nodes! * Add create_snap_to_grid_dataframe function
|
I've tested with a local editable install of numba celltree. This needs: https://pypi.org/project/numba-celltree/0.1.8/ The conda-forge recipe will probably be up soon, I can merge it by Monday. If we update the pixi.toml then, I expect the tests to run green. |
|
I just merged the numba_celltree conda-forge PR for version 0.1.8. Updating the pixi lockfile tomorrow should do the trick and get this green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds edge cases mentioned in: #262
Tests will fail without any fix.