Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #134 merge partitions with inconsistent grids amongst partitions #216

Merged
merged 27 commits into from
Feb 14, 2024
Merged

Issue #134 merge partitions with inconsistent grids amongst partitions #216

merged 27 commits into from
Feb 14, 2024

Commits on Feb 9, 2024

  1. Start working on issue, deactivate some breaking validation, add some… 

    … todos
    @JoerivanEngelen
    JoerivanEngelen committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    65c34b7 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Merge branch 'main' into issue_134_merge_partitions_1D2D

    @JoerivanEngelen
    JoerivanEngelen committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    4062710 View commit details
    Browse the repository at this point in the history

  2. * Add sizes property 

    * Add ``max_face_node_dimension`` property for Ugrid2D
* Add ``max_connectivity_dimensions`` property
    @JoerivanEngelen
    JoerivanEngelen committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    92ab064 View commit details
    Browse the repository at this point in the history

  3. Update changelog

    @JoerivanEngelen
    JoerivanEngelen committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    9866cb2 View commit details
    Browse the repository at this point in the history

  4. * Support merging partitions with different grids per partition 

    * Add function to maybe pad connectivity max dims
* Group data objects and other vars by gridname
    @JoerivanEngelen
    JoerivanEngelen committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    e2bd159 View commit details
    Browse the repository at this point in the history

  5. Format

    @JoerivanEngelen
    JoerivanEngelen committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    ba6e259 View commit details
    Browse the repository at this point in the history

  6. Update changelog

    @JoerivanEngelen
    JoerivanEngelen committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    151f416 View commit details
    Browse the repository at this point in the history

  7. Add test

    @JoerivanEngelen
    JoerivanEngelen committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    68b2d94 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Support merging partitions with inconsistent grids

    @JoerivanEngelen
    JoerivanEngelen committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    8ab89ad View commit details
    Browse the repository at this point in the history

  2. Fix comments and drop mesh1d_nEdges in paritition as well.

    @JoerivanEngelen
    JoerivanEngelen committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    30d12b9 View commit details
    Browse the repository at this point in the history

  3. Fix validation

    @JoerivanEngelen
    JoerivanEngelen committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    5815063 View commit details
    Browse the repository at this point in the history

  4. Add test

    @JoerivanEngelen
    JoerivanEngelen committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    147f3d4 View commit details
    Browse the repository at this point in the history

  5. Add validation if vars in all data objects and ensure all other_vars … 

    …are added to merged
    @JoerivanEngelen
    JoerivanEngelen committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    edfa12b View commit details
    Browse the repository at this point in the history

  6. Add extra tests and adapt some tests

    @JoerivanEngelen
    JoerivanEngelen committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    1570561 View commit details
    Browse the repository at this point in the history

  7. format

    @JoerivanEngelen
    JoerivanEngelen committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    92fd23f View commit details
    Browse the repository at this point in the history

  8. Update changelog

    @JoerivanEngelen
    JoerivanEngelen committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    0c85d0b View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Rename max_connectivity_dimensions to max_connectivity_sizes and let … 

    …the former method return a tuple of names instead
    @JoerivanEngelen
    JoerivanEngelen committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    22d93a2 View commit details
    Browse the repository at this point in the history

  2. Remove duplicate message

    @JoerivanEngelen
    JoerivanEngelen committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    8c465bc View commit details
    Browse the repository at this point in the history

  3. Add type annotations and add return None

    @JoerivanEngelen
    JoerivanEngelen committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    694c31c View commit details
    Browse the repository at this point in the history

  4. format

    @JoerivanEngelen
    JoerivanEngelen committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    c925667 View commit details
    Browse the repository at this point in the history

  5. type annotate separate_variables and fix comment

    @JoerivanEngelen
    JoerivanEngelen committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    0eb60f4 View commit details
    Browse the repository at this point in the history

  6. Add type annotation

    @JoerivanEngelen
    JoerivanEngelen committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    96f814b View commit details
    Browse the repository at this point in the history

  7. Remove useless filter loop

    @JoerivanEngelen
    JoerivanEngelen committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    d9b3494 View commit details
    Browse the repository at this point in the history

  8. Type annotate merge_partitions

    @JoerivanEngelen
    JoerivanEngelen committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    4b262e4 View commit details
    Browse the repository at this point in the history

  9. Simplify logic with reviewer's suggestions

    @JoerivanEngelen
    JoerivanEngelen committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    365ee19 View commit details
    Browse the repository at this point in the history

  10. format

    @JoerivanEngelen
    JoerivanEngelen committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    20181c3 View commit details
    Browse the repository at this point in the history

  11. Fix typo in docstring

    @JoerivanEngelen
    JoerivanEngelen committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    a96d298 View commit details
    Browse the repository at this point in the history