Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

39 setup urban sewer network from global data project overview #60

Draft
wants to merge 59 commits into
base: main
Choose a base branch
from

Conversation

xldeltares
Copy link
Collaborator

@xldeltares xldeltares commented Aug 15, 2023

Issue addressed

Fixes #39

Explanation

Explain how you addressed the bug/feature request, what choices you made and why.

Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Tests & pre-commit hooks pass
  • Updated documentation if needed
  • Updated changelog.rst if needed

Todo:

  • possible to keep it to one additional yml file?

Additional Notes (optional)

Add any additional notes or information that may be helpful.

@xldeltares xldeltares linked an issue Aug 15, 2023 that may be closed by this pull request
5 tasks
@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 36 Code Smells

No Coverage information No Coverage information
8.0% 8.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link

sonarcloud bot commented Jan 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

3 Security Hotspots

See analysis details on SonarCloud

@veenstrajelmer veenstrajelmer marked this pull request as draft October 15, 2024 12:11
@veenstrajelmer
Copy link
Collaborator

ci is failing, errors:

=========================== short test summary info ===========================
FAILED tests/test_hydromt.py::test_model_build[piave] - ValueError: cannot reindex or align along dimension 'network1d_nGeometryNodes' because of conflicting dimension sizes: {2273, 2239}
FAILED tests/test_hydromt.py::test_model_build[urbansewernetwork] - AttributeError: 'NoneType' object has no attribute 'initial'
=========== 2 failed, 12 passed, 195 warnings in 217.89s (0:03:37) ============

Copy link

sonarcloud bot commented Oct 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup urban sewer network from global data - Project Overview 💯
3 participants