-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix setup channels and 2d1d links #133
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not necessary anymore to drop them as dropping the variables related to the 1d2dlinks already results in the dimensions being dropped
… file), including testcase
Quality Gate passedIssues Measures |
@hboisgon I addressed your points! It will not affect the examples as setup_channels is not included in the examples (thus they are not affected by the changes). I will make an issue that it would be good to include it, as such an example can also be used for tests |
Issue addressed
Fixes #131 and #132
Explanation
Some typos and incorrect variable types resulted in errors being raised. This PR solves this by removing the typos and adapting some of the code copied from hydrolib to be able to work with correct variable types. This is not an improvement of the functionality, but merely bigfixing
Checklist
main