Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all pre-commit hooks #116

Merged
merged 7 commits into from
Nov 24, 2023
Merged

Fix all pre-commit hooks #116

merged 7 commits into from
Nov 24, 2023

Conversation

hboisgon
Copy link
Contributor

@hboisgon hboisgon commented Nov 21, 2023

Issue addressed

Fixes #28

Explanation

Fix ruff errors.

Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Tests & pre-commit hooks pass
  • Updated documentation if needed
  • Updated changelog.rst if needed

@hboisgon hboisgon self-assigned this Nov 21, 2023
Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@xldeltares xldeltares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review OK!

@xldeltares xldeltares merged commit 89d5702 into main Nov 24, 2023
7 checks passed
@xldeltares xldeltares deleted the precommit branch November 24, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pre-commit fails on ruff check
2 participants