Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

112 improvements of structures #113

Merged
merged 6 commits into from
Nov 15, 2023
Merged

112 improvements of structures #113

merged 6 commits into from
Nov 15, 2023

Conversation

xldeltares
Copy link
Collaborator

@xldeltares xldeltares commented Nov 15, 2023 •
edited
Loading

Issue addressed

Fixes #112

Explanation

  • allow duplicated crosssections and use this setting as default for structures
  • allow structure name
  • write compound structure for multiple structures at the same location

Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Tests pass
  • pre-commit hooks pass
  • Updated documentation if needed
  • Updated changelog.rst if needed

Additional Notes (optional)

Add any additional notes or information that may be helpful.

@xldeltares xldeltares linked an issue Nov 15, 2023 that may be closed by this pull request
Bug in structures #112
Closed
2 tasks
@xldeltares xldeltares changed the title 112 bug in structures 112 improvements of structures Nov 15, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@xldeltares
Copy link
Collaborator Author

Authored by Boyan and reviewed by Xiaohan.

@xldeltares xldeltares merged commit 96b974f into main Nov 15, 2023
6 of 7 checks passed
@xldeltares xldeltares deleted the 112-bug-in-structures branch November 15, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in structures
1 participant
@xldeltares