Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

105 update meshkernel api calls to version 300 #109

Merged
merged 28 commits into from
Nov 20, 2023

Conversation

veenstrajelmer
Copy link
Collaborator

@veenstrajelmer veenstrajelmer commented Oct 27, 2023

Issue addressed

Fixes #105

Explanation

There were major hydrolib-core changes to facilitate meshkernel 3.0.0. Actually it was based on meshkernel 2.0.2, so it makes sense that it could not work with meshkernel 2.1.0. The hydrolib-core PR contains all changes: https://github.com/Deltares/HYDROLIB-core/pull/574/files

Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Tests & pre-commit hooks pass
  • Updated documentation if needed
  • Updated changelog.rst if needed

Actual checklist:

  • green testbank with hydrolib-core branch 569-bumping-meshkernel-version-to-latest-v300
  • remove mesh1d_set where possible, should be done by hydrolib-core when needed
  • Check amount of nodes/edges/faces in mesh1d, mesh2d and links in resulting grid. Check whether the resulting grid is not duplicated (double generated) and update hydrolib-core testbank if needed.
  • move hydrolib-core dependency from branch to release (Integrate MeshKernelPy >=3.0.0 HYDROLIB-core#574) (envs and toml)
  • move xugrid dependency from branch to release (updated meshkernel apicalls to meshkernel v3 xugrid#171) (envs and toml)

@veenstrajelmer veenstrajelmer linked an issue Oct 27, 2023 that may be closed by this pull request
4 tasks
@xldeltares
Copy link
Collaborator

Hi @veenstrajelmer , I had a quick check of the PR. both the changes and the model generated seems fine.

@xldeltares
Copy link
Collaborator

Hi @veenstrajelmer, just found a new error from hydromt-delft3dfm python 3.9 test bench: "ImportError: cannot import name 'UnionType' from 'types')" when calling from meshkernel.meshkernel import MeshKernel. Do you know if that is because meshkernel does not support python 3.9 anymore?

Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@xldeltares xldeltares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review is OK!

@xldeltares xldeltares merged commit 25e7557 into main Nov 20, 2023
6 of 7 checks passed
@xldeltares xldeltares deleted the 105-update-meshkernel-api-calls-to-version-300 branch November 20, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update meshkernel API calls to version 3.0.0
2 participants