-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
105 update meshkernel api calls to version 300 #109
105 update meshkernel api calls to version 300 #109
Conversation
Hi @veenstrajelmer , I had a quick check of the PR. both the changes and the model generated seems fine. |
Hi @veenstrajelmer, just found a new error from hydromt-delft3dfm python 3.9 test bench: "ImportError: cannot import name 'UnionType' from 'types')" when calling |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review is OK!
Issue addressed
Fixes #105
Explanation
There were major hydrolib-core changes to facilitate meshkernel 3.0.0. Actually it was based on meshkernel 2.0.2, so it makes sense that it could not work with meshkernel 2.1.0. The hydrolib-core PR contains all changes: https://github.com/Deltares/HYDROLIB-core/pull/574/files
Checklist
Updated tests or added new testsmain
Updated documentation if neededActual checklist: