Correct from_meshkernel_mesh2d_to_ugrid_mesh2d function

Deltares · Aug 23, 2023 · 3725873 · 3725873
1 parent 9af3f82
commit 3725873
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/docs/examples/06_working_with_meshkernel_triangular_mesh.ipynb b/docs/examples/06_working_with_meshkernel_triangular_mesh.ipynb
@@ -4,7 +4,7 @@
    "cell_type": "markdown",
    "metadata": {},
    "source": [
-    "# Writing meshkernel meshes to ugrid file\n",
+    "# Writing an unstructured meshkernel meshes to ugrid file\n",
     "\n",
     "This is a basic introduction for writing meshkernel meshes to file.\n",
     "\n",
@@ -215,7 +215,7 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 12,
+   "execution_count": 11,
    "metadata": {},
    "outputs": [],
    "source": [
@@ -245,6 +245,13 @@
     "        \"Conventions\": \"CF-1.6 UGRID-1.0/Deltares-0.8\"}\n",
     "    ug.attribute_global_define(conventions)"
    ]
+  },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "metadata": {},
+   "outputs": [],
+   "source": []
   }
  ],
  "metadata": {

diff --git a/ugrid/ugrid.py b/ugrid/ugrid.py
@@ -531,10 +531,11 @@ def fill_int_face_array(face_array):
                     result[current_index : current_index + num_face_nodes] = face_array[
                         index : index + num_face_nodes
                     ]
+                    index = index + num_face_nodes
+                return result
 
             face_nodes_flat_array = fill_int_face_array(mesh2d.face_nodes)
             face_edges_flat_array = fill_int_face_array(mesh2d.face_edges)
-            edge_faces_flat_array = fill_int_face_array(mesh2d.edge_faces)
 
             return UGridMesh2D(
                 name=name,
@@ -543,7 +544,7 @@ def fill_int_face_array(face_array):
                 edge_node=mesh2d.edge_nodes,
                 face_nodes=face_nodes_flat_array,
                 face_edges=face_edges_flat_array,
-                edge_faces=edge_faces_flat_array,
+                edge_faces=mesh2d.edge_faces,
                 edge_x=mesh2d.edge_x,
                 edge_y=mesh2d.edge_y,
                 face_x=mesh2d.face_x,