Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OrdinaryDiffEq internals #1784

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

SouthEndMusic
Copy link
Collaborator

@SouthEndMusic SouthEndMusic marked this pull request as draft September 2, 2024 03:53
@SouthEndMusic
Copy link
Collaborator Author

SouthEndMusic commented Oct 25, 2024

Things I changed:

  • Replace LineSearches.jl by LineSearch.jl (part of SciML). Specifically, I use LineSearch.BackTracking instead of my wrapper of LineSearches.BackTracking. It might turn out that this wrapper is still needed.
  • Use the latest master of OrdinaryDiffEq.jl (I had quite some problems installing directly from the GitHub repository, so I now use a path to the repo locally as a POC). Using NonlinearSolveAlg now works with finite difference, but using ForwardDiff is still broken. OrdinaryDiffEqRosenbrock is also broken.

It must be noted that even though NonlinearSolveAlg with finite difference and BackTracking from LineSearch.jl works, I observed a huge drop in performance for the HWS model. Interestingly, looking at the profile reveals that this performance drop is at least in part due to runtime dispatch and allocations in OrdinaryDiffEqNonlinearSolve, so that subpackage is clearly not mature enough to be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of OrdinaryDiffEq internals usage
1 participant