Feature/gridedit 785 refactor mesh refinement #263
Conversation
| @@ -36,6 +36,9 @@ namespace meshkernel::averaging | |||
| public: | |||
| virtual ~AveragingStrategy() = default; | |||
|
|
|||
| /// @brief Reset the state of the averaging strategy, ready for the next calculation. | |||
There was a problem hiding this comment.
Please add param interpolationPoint to doxy
| @@ -97,7 +99,9 @@ namespace meshkernel::averaging | |||
| // Setup | |||
| Point p = Point(0.0, 0.0); | |||
| std::unique_ptr<AveragingStrategy> pStrategy = AveragingStrategyFactory::GetAveragingStrategy(GetParam().method_, 1, | |||
There was a problem hiding this comment.
Unrelated. method_: can use m_ prefix rather than _ suffix
There was a problem hiding this comment.
Changing to: GetParam().m_method
does not compile
| @@ -36,6 +36,9 @@ namespace meshkernel::averaging | |||
| public: | |||
| virtual ~AveragingStrategy() = default; | |||
|
|
|||
| /// @brief Reset the state of the averaging strategy, ready for the next calculation. | |||
| virtual void Reset(const Point& interpolationPoint) = 0; | |||
|
|
|||
| /// @brief Adds the specified sample point. | |||
| /// @param[in] samplePoint The sample point to add to this strategy. | |||
| /// @param[in] sampleValue The value associated with the sample point. | |||
There was a problem hiding this comment.
Never liked the how samplePoint is a dummy arg in most derived classes. Only ClosestAveragingStrategy and InverseWeightedAveragingStrategy use it. Having a SetSamplePoint method in the base is also a bad idea because again, only used when ClosestAveragingStrategy and InverseWeightedAveragingStrategy arte created.
Can you think of a better way to do this?
There was a problem hiding this comment.
The only way I can see to resolve this is going back to the orginal, allocating a new object for each interpolation point.
…mesh refinement constructor
No description provided.