Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for base volume, backfill fix #2081

Merged
merged 4 commits into from
Nov 10, 2024
Merged

Conversation

yellowBirdy
Copy link
Contributor

  • Included a fix for volume calculation on base, which incorrectly returned 0
  • refactored address discovery into a function
  • added hardcodded addresses for backfill when necessary

@llamatester
Copy link

The nabla adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts dexs nabla

🦙 Running NABLA adapter 🦙
---------------------------------------------------
Start Date:	Fri, 08 Nov 2024 23:02:02 GMT
End Date:	Sat, 09 Nov 2024 23:02:02 GMT
---------------------------------------------------

ReferenceError: dailyRevenue is not defined
    at fetch (/home/runner/work/dimension-adapters/dimension-adapters/dexs/nabla/index.ts:171:33)
    at async getChainResult (/home/runner/work/dimension-adapters/dimension-adapters/adapters/utils/runAdapter.ts:51:18)
    at async Promise.all (index 1)
    at async runAdapter (/home/runner/work/dimension-adapters/dimension-adapters/adapters/utils/runAdapter.ts:27:20)
    at async /home/runner/work/dimension-adapters/dimension-adapters/cli/testAdapter.ts:84:21 {
  chain: 'base'
}

@llamatester
Copy link

The nabla adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts dexs nabla

🦙 Running NABLA adapter 🦙
---------------------------------------------------
Start Date:	Fri, 08 Nov 2024 23:04:51 GMT
End Date:	Sat, 09 Nov 2024 23:04:51 GMT
---------------------------------------------------

ARBITRUM 👇
Backfill start time: 15/8/2024
Daily fees: 74
└─ Methodology: All fees comes from the user.
Daily protocol revenue: 0
└─ Methodology: Currently no fees are taken by the protocl.
Daily user fees: 74
└─ Methodology: User pays between 0.01% and 0.1% fees on each swap.
Daily volume: 147.15 k
End timestamp: 1731193490 (2024-11-09T23:04:50.000Z)


BASE 👇
Backfill start time: 12/9/2024
Daily fees: 159
└─ Methodology: All fees comes from the user.
Daily protocol revenue: 0
└─ Methodology: Currently no fees are taken by the protocl.
Daily user fees: 159
└─ Methodology: User pays between 0.01% and 0.1% fees on each swap.
Daily volume: 318.40 k
End timestamp: 1731193490 (2024-11-09T23:04:50.000Z)

@dtmkeng dtmkeng merged commit 7b30089 into DefiLlama:master Nov 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants