Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nbala finance: dex fees and volume #2069

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Conversation

yellowBirdy
Copy link
Contributor

No description provided.

@llamatester
Copy link

The nabla adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts dexs nabla

🦙 Running NABLA adapter 🦙
---------------------------------------------------
Start Date:	Sat, 02 Nov 2024 22:42:07 GMT
End Date:	Sun, 03 Nov 2024 22:42:07 GMT
---------------------------------------------------

ARBITRUM 👇
Backfill start time: 15/8/2024
Daily fees: 101
└─ Methodology: All fees comes from the user.
Daily protocol revenue: 0
└─ Methodology: Currently no fees are taken by the protocl.
Daily user fees: 101
└─ Methodology: User pays between 0.01% and 0.1% fees on each swap.
Daily volume: 202.80 k
End timestamp: 1730673726 (2024-11-03T22:42:06.000Z)


BASE 👇
Backfill start time: 12/9/2024
Daily fees: 0
└─ Methodology: All fees comes from the user.
Daily revenue: 0
Daily user fees: 0
└─ Methodology: User pays between 0.01% and 0.1% fees on each swap.
Daily volume: 0
End timestamp: 1730673726 (2024-11-03T22:42:06.000Z)

volumeLogs.forEach((logs, i) => {
logs.forEach((e: any) => {
dailyVolume.add(e.tokenIn, e.amountIn)
dailyVolume.add(e.tokenOut, e.amountOut)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

volume should count one side, i think should count only tokenOut


volumeLogs.forEach((e, i) => {
dailyVolume.add(e.tokenIn, e.amountIn)
dailyVolume.add(e.tokenOut, e.amountOut)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

volume should count one side, i think should count only tokenOut

@llamatester
Copy link

The nabla adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts dexs nabla

🦙 Running NABLA adapter 🦙
---------------------------------------------------
Start Date:	Tue, 05 Nov 2024 11:19:51 GMT
End Date:	Wed, 06 Nov 2024 11:19:51 GMT
---------------------------------------------------

ARBITRUM 👇
Backfill start time: 15/8/2024
Daily fees: 276
└─ Methodology: All fees comes from the user.
Daily protocol revenue: 0
└─ Methodology: Currently no fees are taken by the protocl.
Daily user fees: 276
└─ Methodology: User pays between 0.01% and 0.1% fees on each swap.
Daily volume: 551.35 k
End timestamp: 1730891990 (2024-11-06T11:19:50.000Z)


BASE 👇
Backfill start time: 12/9/2024
Daily fees: 18
└─ Methodology: All fees comes from the user.
Daily revenue: 0
Daily user fees: 18
└─ Methodology: User pays between 0.01% and 0.1% fees on each swap.
Daily volume: 0
End timestamp: 1730891990 (2024-11-06T11:19:50.000Z)

@dtmkeng dtmkeng merged commit 97ac817 into DefiLlama:master Nov 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants