Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XY Finance: list XY Finance on the aggregators page #1931

Merged
merged 2 commits into from
Oct 1, 2024
Merged

XY Finance: list XY Finance on the aggregators page #1931

merged 2 commits into from
Oct 1, 2024

Conversation

coolryanc
Copy link
Contributor

@coolryanc coolryanc commented Sep 19, 2024 •
edited
Loading

Hi DL team @g1nt0ki @dtmkeng, this is XY Finance, we'd like to list us on https://defillama.com/aggregators, here is the PR could you please help review. 🙏

Quick question, other than submitting the PR here, do we also need to submit PR to https://github.com/DefiLlama/defillama-server? Please let us know, thanks. 🙇

llama server PR: DefiLlama/defillama-server#8150

Evidence

yarn test aggregators xy-finance
volume

@llamatester
Copy link

The xy-finance adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts aggregators xy-finance

🦙 Running XY-FINANCE adapter 🦙
---------------------------------------------------
Start Date:	Wed, 18 Sep 2024 00:00:00 GMT
End Date:	Thu, 19 Sep 2024 00:00:00 GMT
---------------------------------------------------

error fetching block TypeError: Cannot read properties of null (reading 'getBlock')
    at _getCurrentChainBlock (/home/runner/work/dimension-adapters/dimension-adapters/node_modules/@defillama/sdk/build/util/blocks.js:84:59)
    at getCurrentChainBlock (/home/runner/work/dimension-adapters/dimension-adapters/node_modules/@defillama/sdk/build/util/blocks.js:76:22)
    at _lookupBlock (/home/runner/work/dimension-adapters/dimension-adapters/node_modules/@defillama/sdk/build/util/blocks.js:204:44)
    at /home/runner/work/dimension-adapters/dimension-adapters/node_modules/@defillama/sdk/build/util/blocks.js:155:26
    at /home/runner/work/dimension-adapters/dimension-adapters/node_modules/p-limit/index.js:23:31
    at run (/home/runner/work/dimension-adapters/dimension-adapters/node_modules/p-limit/index.js:23:43)
    at /home/runner/work/dimension-adapters/dimension-adapters/node_modules/p-limit/index.js:45:20
    at runNextTicks (node:internal/process/task_queues:60:5)
    at listOnTimeout (node:internal/timers:538:9)
    at processTimers (node:internal/timers:512:7)
error fetching block TypeError: Cannot read properties of null (reading 'getBlock')
    at _getCurrentChainBlock (/home/runner/work/dimension-adapters/dimension-adapters/node_modules/@defillama/sdk/build/util/blocks.js:84:59)
    at getCurrentChainBlock (/home/runner/work/dimension-adapters/dimension-adapters/node_modules/@defillama/sdk/build/util/blocks.js:76:22)
    at _lookupBlock (/home/runner/work/dimension-adapters/dimension-adapters/node_modules/@defillama/sdk/build/util/blocks.js:204:44)
    at /home/runner/work/dimension-adapters/dimension-adapters/node_modules/@defillama/sdk/build/util/blocks.js:155:26
    at /home/runner/work/dimension-adapters/dimension-adapters/node_modules/p-limit/index.js:23:31
    at run (/home/runner/work/dimension-adapters/dimension-adapters/node_modules/p-limit/index.js:23:43)
    at /home/runner/work/dimension-adapters/dimension-adapters/node_modules/p-limit/index.js:45:20
    at runNextTicks (node:internal/process/task_queues:60:5)
    at listOnTimeout (node:internal/timers:538:9)
    at processTimers (node:internal/timers:512:7)
error fetching block TypeError: Cannot read properties of null (reading 'getBlock')
    at _getCurrentChainBlock (/home/runner/work/dimension-adapters/dimension-adapters/node_modules/@defillama/sdk/build/util/blocks.js:84:59)
    at getCurrentChainBlock (/home/runner/work/dimension-adapters/dimension-adapters/node_modules/@defillama/sdk/build/util/blocks.js:76:22)
    at _lookupBlock (/home/runner/work/dimension-adapters/dimension-adapters/node_modules/@defillama/sdk/build/util/blocks.js:204:44)
    at /home/runner/work/dimension-adapters/dimension-adapters/node_modules/@defillama/sdk/build/util/blocks.js:155:26
    at /home/runner/work/dimension-adapters/dimension-adapters/node_modules/p-limit/index.js:23:31
    at run (/home/runner/work/dimension-adapters/dimension-adapters/node_modules/p-limit/index.js:23:43)
    at /home/runner/work/dimension-adapters/dimension-adapters/node_modules/p-limit/index.js:45:20
    at runNextTicks (node:internal/process/task_queues:60:5)
    at listOnTimeout (node:internal/timers:538:9)
    at processTimers (node:internal/timers:512:7)
XY Finance fetch chain numbers error: {}
XY Finance fetch chain zksync error: {}
ETHEREUM 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 38.55 k
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


SCROLL 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 197.48 k
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


MANTLE 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 14.95 k
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


LINEA 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 7.53 k
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


BASE 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 144.93 k
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


ARBITRUM 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 628.24 k
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


ZKSYNC 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 0
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


BSC 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 114.87 k
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


POLYGON 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 47.54 k
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


KLAYTN 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 0
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


POLYGON_ZKEVM 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 1.03 k
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


AVAX 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 27.11 k
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


OPTIMISM 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 107.60 k
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


CRONOS 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 17.14 k
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


FANTOM 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 0
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


ASTAR 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 0
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


KCC 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 14
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


MOONRIVER 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 0
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


THUNDERCORE 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 0
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


NUMBERS 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 0
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


WEMIX 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 0
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


BLAST 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 297
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


XLAYER 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 220
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


TAIKO 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 41.99 k
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)


CRONOS_ZKEVM 👇
Backfill start time: 10/8/2023
NO METHODOLOGY SPECIFIED
Daily bridge volume: 256
End timestamp: 1726703999 (2024-09-18T23:59:59.000Z)

@dtmkeng
Copy link
Contributor

dtmkeng commented Sep 20, 2024

could you revert change package.json and package-lock.json ?

@coolryanc coolryanc force-pushed the feature/xy_finance_bridge-aggregator branch from 8c80a7f to 241a935 Compare September 20, 2024 15:19
@coolryanc
Copy link
Contributor Author

@dtmkeng sure, reverted.

@dtmkeng
Copy link
Contributor

dtmkeng commented Sep 21, 2024

i think should move under https://github.com/DefiLlama/dimension-adapters/tree/master/bridge-aggregator is it bridge-aggregator

@coolryanc
Copy link
Contributor Author

@dtmkeng thanks, updated.

@coolryanc
Copy link
Contributor Author

hey @dtmkeng could you please help merge the PR if it looks good to you 🙏

@dtmkeng
Copy link
Contributor

dtmkeng commented Sep 30, 2024

i can merge but config for show bridge agg it not ready yet

@coolryanc
Copy link
Contributor Author

@dtmkeng Thanks, just to clarify, we also need to raise a PR to https://github.com/DefiLlama/defillama-server?

@coolryanc coolryanc mentioned this pull request Oct 1, 2024
Closed
@DefiLlama DefiLlama deleted a comment from llamatester Oct 1, 2024
@dtmkeng dtmkeng merged commit 7fa3e2c into DefiLlama:master Oct 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reallyfe Reallyfe Reallyfe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coolryanc @llamatester @dtmkeng @Reallyfe