Add new command: "AutoEmpty" #349
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #349 +/- ##
==========================================
+ Coverage 78.62% 78.76% +0.14%
==========================================
Files 64 66 +2
Lines 2610 2689 +79
Branches 470 483 +13
==========================================
+ Hits 2052 2118 +66
- Misses 515 526 +11
- Partials 43 45 +2 ☔ View full report in Codecov by Sentry. |
edenhaus
force-pushed
the
feature/CommandAutoEmpty
branch
from
b2617d8
to
e68d406
Compare
- add MappingProxyType - add ruff ignore 'noqa: FBT001, FBT002' - add ruff ignore 'noqa: FBT003' - fix lint in DisplayNameStrEnum
- remove 'noqa: FBT003' - extend with fail test case
edenhaus
reviewed
Dec 11, 2023
| @@ -88,6 +88,55 @@ def __hash__(self) -> int: | |||
| return hash(self._value_) | |||
|
|
|||
|
|
|||
| @unique | |||
| class DisplayNameStrEnum(Enum): | |||
There was a problem hiding this comment.
Why are you adding this enum back?
There was a problem hiding this comment.
Because inside the event auto_empty.py in class AutoEmptyMod i used instead of integer enums - string enums. For that I copy the existing int enum definition to have it with same functions for string enum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new command: "AutoEmpty"
getAutoEmptysetAutoEmptysmartis also a possible option.