Skip to content

Commit

Permalink
Merge pull request apiture#22 from DavidBiesack/github-actions-node-20
Browse files Browse the repository at this point in the history
Update GitHub actions to use Node 20
  • Loading branch information
DavidBiesack authored Mar 16, 2024
2 parents 99e45e9 + 7f2592f commit 1f85fbf
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

strategy:
matrix:
node-version: [12.x, 14.x, 16.x]
node-version: [16.x, 18.x, 20.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/npm-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20
- run: npm ci
- run: npm test

Expand All @@ -26,7 +26,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20
registry-url: https://registry.npmjs.org/
- run: npm ci
- run: npm publish --access public
Expand Down
19 changes: 11 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -217,9 +217,8 @@ Remove the `webhooks` object, if present.

### ⤓ JSON Schema related changes

OAS 3.0 uses an earlier JSON Schema version (Draft 4). The tool convert `examples`
in schemas
to a single `example`.
OAS 3.0 uses an earlier JSON Schema version (Draft 7). The tool converts `examples`
in schemas to a single `example`.

As a special case, if the resulting `example` includes an `id`, it is
deleted if the `--delete-examples-with-id` CLI option is set.
Expand Down Expand Up @@ -321,7 +320,7 @@ be possible (`properties`, `allOf` etc.)

The tool removes the `unevaluatedProperties` value, introduced in later
versions of JSON Schema,
as this is not supported in JSON Schema Draft 4
as this is not supported in OAS 3.0 JSON Schema Draft 7
used in OAS 3.0.

```yaml
Expand Down Expand Up @@ -447,10 +446,14 @@ format: binary
Currently, the tool does not support the following situations.
Contributions welcome!

* `openapi-down-convert` does not convert `exclusiveMinimum` and `exclusiveMaximum`
as defined in JSON Schema 2012-12; these handled differently in JSON Schema Draft 4
used in OAS 3.0.
* Webhooks are not addressed.
* `openapi-down-convert` does not convert
`exclusiveMinimum` and
`exclusiveMaximum`,
`unevaluatedProperties`,
`patternProperties`
as defined in JSON Schema 2012-12; these are not supported in JSON Schema Draft 7
used in OAS 3.0
* Webhooks are not removed. Contributions welcome!
* The tool only supports self-contained documents. It does not follow or resolve
external `$ref` documents embedded in the source document.
* Request body and response body `content` object transformations, such as
Expand Down

0 comments on commit 1f85fbf

Please sign in to comment.