Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append : to ns #20

Merged
merged 1 commit into from
May 8, 2024
Merged

Append : to ns #20

merged 1 commit into from
May 8, 2024

Conversation

t4sk
Copy link
Contributor

@t4sk t4sk commented May 2, 2024

rsmq (js) appends : to ns

https://github.com/smrchy/rsmq/blob/5c507c2ae97145fbdef7369da52dc69b105e0cc6/_src/index.ts#L62

Here is the example of queues created in rust implementation and JS.
Redis keys without : between ns and queue name are created by this rust implementation.
Ones with : are created by JS implementation.

> redis-cli --scan --pattern '*'
rsmq:QUEUES
rsmqQUEUES
rsmqtest:Q
rsmq:test:Q

This implementation does not. So this PR changes the code to align the queue name with rsmq (js)

@DavidBM
Copy link
Owner

DavidBM commented May 8, 2024

Thanks for the MR! I will make a couple of changes and I'm happy to merge it!

@DavidBM DavidBM merged commit 709a7d8 into DavidBM:master May 8, 2024
1 check passed
@DavidBM
Copy link
Owner

DavidBM commented May 8, 2024

Merged as is. Thanks for that! 🙇 I will publish it under version 10 of the crate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants