Bugfix 48 creator query too narrow #124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iannesbitt
requested review from
mbjones,
datadavev and
taojing2002
as code owners
|
If these queries test ok, I can also add a PR for DataONEorg/dataone-cn-index#1 with the same changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the weekend ping. This PR attempts to broaden support for the types of creator role that can be defined in Schema.org JSON-LD metadata. I'm having trouble getting all of the pieces running on my machine, so these changes have not been tested.
Notes:
I added two sparql queries, one for the creator role definition without a list (sometimes used when there is only one creator) and one for the creator role definition WITH an ordered list. I commented with examples of each, and added tests and systemmetadata for each.
I did not add a query for author email as Matt Matt demoed here, as I did not see a field for author email defined in the Solr schema. If someone can suggest what Solr field to use for email and/or ORCiD, I will add those to the query.
I'm adding @artntek to the list of reviewers since I imagine he has a working setup and can test the changes.