recommender: Initial support for third-party replica recommenders #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iksaif
changed the title
iksaif
force-pushed
the
corentin.chary/replica-recommender
branch
from
b0a01b3
to
05119ca
Compare
nickbirnberg
approved these changes
Oct 11, 2024
vboulineau
reviewed
Oct 15, 2024
bundle/manifests/watermarkpodautoscaler.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
vboulineau
previously approved these changes
Oct 16, 2024
dd-mergequeue
bot
dismissed stale reviews from vboulineau and github-actions[bot]
The base branch was changed.
This is a first step to implement the interface defined in DataDog/agent-payload#348 Currently this simply adds a non-implemented recommender client and the necesary logic to handle the results. It does not allow the usage all the features made available by the recommendation API and keep it to the minimum required to make use of it (for example simple TargetType). Simple tests have been implemented and this was implemented to re-use as much code as possible in the replica_calculator. Follow-up PRs will actually implement the recommender client and add the necessary tests and documentation.
iksaif
force-pushed
the
corentin.chary/replica-recommender
branch
from
a833bf7
to
eac6992
Compare
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step to implement the interface defined in DataDog/agent-payload#348
Currently this simply adds a non-implemented recommender client and the necesary logic to handle
the results. It does not allow the usage all the features made available by the recommendation
API and keep it to the minimum required to make use of it (for example simple TargetType).
Simple tests have been implemented and this was implemented to re-use as much code as possible in the replica_calculator.
Follow-up PRs will
This PR is currently based on lenaic/CONTINT-4412