tool: add a script to centralize golang version update #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clamoriniere
force-pushed
the
clamoriniere/verify-golang-version
branch
from
59ebbc4
to
b04aa3f
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
clamoriniere
force-pushed
the
clamoriniere/verify-golang-version
branch
from
b04aa3f
to
adc7415
Compare
the script is taking the golang version present in the go.mod file and apply patch on the differents files that contains the golang version. for example Dockerfile and github workflow files.
clamoriniere
force-pushed
the
clamoriniere/verify-golang-version
branch
from
adc7415
to
83b0d6b
Compare
L3n41c
previously approved these changes
Jul 10, 2024
clamoriniere
dismissed stale reviews from L3n41c and github-actions[bot]
via
bb3030b
clamoriniere
force-pushed
the
clamoriniere/verify-golang-version
branch
from
bb3030b
to
83232da
Compare
clamoriniere
force-pushed
the
clamoriniere/verify-golang-version
branch
from
83232da
to
18187d9
Compare
|
@L3n41c PR updated and ready for a second path. |
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
the New script is taking the version from the
go.modfile thank to thego mod edit --jsoncommand ouput.The idea is to first update the golang version in the
go.modfile, then run the commandmake update-golangthat will patch all the files that contains the golang version.commits:
Motivation
To not forget to update the golang version in one of the many file that have the golang version in parameter.
we needed to have a solution to centralise the update of the golang version, but also to verify that all file are in sync
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Write there any instructions and details you may have to test your PR.