Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPLAT-1532: auto renew passwords #16

Merged
merged 6 commits into from
May 30, 2024

Conversation

bhowe34
Copy link

@bhowe34 bhowe34 commented May 28, 2024

Changes:

  • updates the periodic function to iterate through all roles and refresh service principal passwords if they are expiring
  • fixes the requests body for adding service principal passwords. The previous body was structured incorrectly so all passwords would use the default TTL of 2 years instead of the specified 10 years.
  • update vault SDK and API packages, this also updated other deps.
  • removed an unused client mock file

Tested locally and verified service principal credentials were refreshed, expired credentials were removed, and access tokens were able to be retrieved after the refresh. I also allowed credentials in use to expire, verified I couldn't retrieve access tokens, then reloaded the plugin so it would refresh the credentials and verified I could successfully retrieve an access token.

@datadog-datadog-prod-us1
Copy link

Software Composition Analysis

We found vulnerabilities in the following libraries (compared 6d64091 against fca7e82):

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 28, 2024

Software Composition Analysis

We found vulnerabilities in the following libraries (compared 6cc99ae against fca7e82):

@bhowe34 bhowe34 changed the title Bhowe34/auto renew passwords PPLAT-1532: auto renew passwords May 28, 2024
@bhowe34 bhowe34 force-pushed the bhowe34/auto-renew-passwords branch from 6d64091 to 6cc99ae Compare May 28, 2024 20:37
backend.go Show resolved Hide resolved
backend.go Show resolved Hide resolved
backend.go Outdated Show resolved Hide resolved
backend.go Show resolved Hide resolved
backend.go Show resolved Hide resolved
backend.go Show resolved Hide resolved
path_service_principal.go Show resolved Hide resolved
@bhowe34 bhowe34 merged commit 9c8569b into bhowe34/0.14.2-access_tokens May 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants