Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROF-9983] Leverage local symbols for otel-profiling-agent #23

Merged
merged 4 commits into from
Jun 25, 2024

Commits on Jun 20, 2024

  1. Configuration menu
    Copy the full SHA
    9efa85c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    036a0ba View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. symbolication: remove noisy error log

    when we only filter out fs.ErrNotExist, we get frequent failures
    in the local development environment with the following error:
    /proc/<pid>/root// is a directory
    
    we seem to think that /proc/<pid>/root// is a executable path,
    this happens for short-lived runc processes where /proc/<pid>/maps
    has "/" as the pathname for the runc executable itself.
    
    so when we try to open the elf file, we first try to read it from
    /proc/<pid>/map_files and (as the process is short lived) when
    this fails, we try to open /proc/<pid>/root// which fails with
    a "is a directory" error instead of fs.ErrNotExist
    
    to fix this, we just ignore all errors returned by GetElf() and
    only log them for debug purposes.
    
    https://github.com/elastic/otel-profiling-agent/blob/0945fe6/libpf/process/process.go#L221-L239
    Gandem committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    967d1d5 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. uploader: fix segfault on failure to init datadog uploader (#26)

    when we fail to initialize the datadog symbol uploader, we set the
    uploader to nil, which will cause a panic later on when handling
    a new executable for symbol upload.
    
    this sets the uploader to symbolication.NewNoopUploader() when the
    datadog uploader is set up, but fails to be initialized.
    Gandem authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d394e12 View commit details
    Browse the repository at this point in the history