wip

DataDog · Jun 11, 2024 · 7ed4617 · 7ed4617
1 parent 7ee4e58
commit 7ed4617
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/libpf/pfelf/file.go b/libpf/pfelf/file.go
@@ -486,6 +486,11 @@ func (f *File) GetGoBuildID() (string, error) {
 	return getGoBuildIDFromNotes(data)
 }
 
+// IsExecutable returns whether the ELF is executable
+func (f *File) IsExecutable() bool {
+	return elf.Type(f.elfHeader.Type) == elf.ET_EXEC
+}
+
 // GetBuildID returns the ELF BuildID if present
 func (f *File) GetBuildID() (string, error) {
 	s := f.Section(".note.gnu.build-id")

diff --git a/processmanager/processinfo.go b/processmanager/processinfo.go
@@ -319,7 +319,11 @@ func (pm *ProcessManager) getELFInfo(pr process.Process, mapping *process.Mappin
 		buildID, _ = ef.GetGoBuildID()
 	}
 
-	pm.reporter.ExecutableMetadata(context.TODO(), fileID, baseName, mapping.Path, buildID)
+	execPath := ""
+	if ef.IsExecutable() {
+		execPath = mapping.Path
+	}
+	pm.reporter.ExecutableMetadata(context.TODO(), fileID, baseName, execPath, buildID)
 
 	return info
 }

diff --git a/reporter/datadog_reporter.go b/reporter/datadog_reporter.go
@@ -512,7 +512,7 @@ func (r *DatadogReporter) getPprofProfile() (profile *pprofile.Profile,
 				loc.Mapping = getDummyMapping(fileIDtoMapping, profile, trace.files[i])
 			}
 			execInfo, exists := r.executables.Get(trace.files[i])
-			if exists {
+			if exists && execInfo.filePath != "" {
 				lastExecPath = execInfo.filePath
 			}
 			sample.Location = append(sample.Location, loc)