Skip to content

Commit

Permalink
Remove lading_signal tokio instrumentation (#1015)
Browse files Browse the repository at this point in the history
In practice the only use lading puts tokio instrumention to is logging and
while it can be useful in development it ends up really clogging logs,
especially the enter exit etcs.

Commit is intended to tidy up logs.

Signed-off-by: Brian L. Troutwine <[email protected]>
  • Loading branch information
blt authored Oct 3, 2024
1 parent cfaaf05 commit b8288a9
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions lading_signal/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,13 @@ impl Broadcaster {
/// Send the signal through any `Watcher` instances.
///
/// Function will NOT block until all peers have ack'ed the signal.
#[tracing::instrument(skip(self))]
pub fn signal(self) {
drop(self.sender);
}

/// Send the signal through to any `Watcher` instances.
///
/// Function WILL block until all peers have ack'ed the signal.
#[tracing::instrument(skip(self))]
pub async fn signal_and_wait(self) {
drop(self.sender);

Expand Down Expand Up @@ -141,7 +139,6 @@ pub struct Watcher {
impl Watcher {
/// Decrease the peer count in the `Broadcaster`, allowing the `Broadcaster` to
/// unblock if waiting for peers. See `Broadcaster::signal_and_wait`.
#[tracing::instrument(skip(self))]
fn decrease_peer_count(&mut self) {
if !self.registered {
// If this instance is not registered the `Broadcaster` will not
Expand Down Expand Up @@ -230,7 +227,6 @@ impl Watcher {
}

/// Register with the `Broadcaster`, returning a new instance of `Watcher`.
#[tracing::instrument(skip(self))]
pub fn register(&self) -> Result<Self, RegisterError> {
if self.signal_received {
// If the shutdown signal has already been received, return with
Expand Down

0 comments on commit b8288a9

Please sign in to comment.