-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(llmobs): submit langchain similarity search spans #9971
Conversation
|
…earch-support' into yahya/add-langchain-similarity-search-support
BenchmarksBenchmark execution time: 2024-08-27 17:59:40 Comparing candidate commit 600a8e1 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics. |
…earch-support' into yahya/add-langchain-similarity-search-support
Datadog ReportBranch report: ✅ 0 Failed, 3219 Passed, 37666 Skipped, 39m 28.81s Total Time |
releasenotes/notes/feat-llmobs-submit-langchain-similarity-search-spans-c5581deda8b6878e.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Yun Kim <[email protected]>
Co-authored-by: Yun Kim <[email protected]>
Co-authored-by: Yun Kim <[email protected]>
…earch-support' into yahya/add-langchain-similarity-search-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit but otherwise lgtm. Thanks!
This PR adds instrumentation to submit langchain vector similarity search spans to LLM Observability. The similarity search spans sent to LLM Observability will contain the following I/O data:
input.value: a text field annotating the search query
output.value: The output document objects for the vector similarity search
Ticket : https://datadoghq.atlassian.net/browse/MLOB-938
Checklist
Reviewer Checklist