Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(llmobs): submit langchain embedding spans #9850

Merged
merged 78 commits into from
Jul 31, 2024
Merged

feat(llmobs): submit langchain embedding spans #9850

merged 78 commits into from
Jul 31, 2024

Commits on Jul 16, 2024

  1. Enable llmobs spans forwarding for embedding calls

    @yahya-mouman
    yahya-mouman committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e495578 View commit details
    Browse the repository at this point in the history

  2. Add operations checklist to catch and log unknown operations

    @yahya-mouman
    yahya-mouman committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    46b8d24 View commit details
    Browse the repository at this point in the history

  3. Add meta tags parser for embeddings

    @yahya-mouman
    yahya-mouman committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    ec37581 View commit details
    Browse the repository at this point in the history

  4. Rename parameter

    @yahya-mouman
    yahya-mouman committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    c82559b View commit details
    Browse the repository at this point in the history

  5. Update the embedding output to be number of embeddings generated

    @yahya-mouman
    yahya-mouman committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    eab0a21 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. add chunk size tag for embedd_documents calls

    @yahya-mouman
    yahya-mouman committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    824554d View commit details
    Browse the repository at this point in the history

  2. re-use the function call for embeddings

    @yahya-mouman
    yahya-mouman committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    c6ed269 View commit details
    Browse the repository at this point in the history

  3. order imports

    @yahya-mouman
    yahya-mouman committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    e2f42f2 View commit details
    Browse the repository at this point in the history

  4. return after operation check

    @yahya-mouman
    yahya-mouman committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    5a36731 View commit details
    Browse the repository at this point in the history

  5. Split parsing between workflow and embedding only cases

    @yahya-mouman
    yahya-mouman committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ca13fe8 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Update ddtrace/llmobs/_integrations/langchain.py 

    Co-authored-by: Yun Kim <[email protected]>
    @yahya-mouman @Yun-Kim
    yahya-mouman and Yun-Kim authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    f876bea View commit details
    Browse the repository at this point in the history

  2. Skipped checking for None as it's implied on the type checks

    @yahya-mouman
    yahya-mouman committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    a58ded9 View commit details
    Browse the repository at this point in the history

  3. reformatted input documents logic based on is_workflow state

    @yahya-mouman
    yahya-mouman committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    f006ba0 View commit details
    Browse the repository at this point in the history

  4. black format

    @yahya-mouman
    yahya-mouman committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    a89ff58 View commit details
    Browse the repository at this point in the history

  5. add release notes

    @yahya-mouman
    yahya-mouman committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    308276d View commit details
    Browse the repository at this point in the history

  6. remove unused variable instantiation

    @yahya-mouman
    yahya-mouman committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    1f717e5 View commit details
    Browse the repository at this point in the history

  7. add wrappers to embed query and documents

    @yahya-mouman
    yahya-mouman committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    8457a17 View commit details
    Browse the repository at this point in the history

  8. add pytests for embed query and embed documents

    @yahya-mouman
    yahya-mouman committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    6f508e8 View commit details
    Browse the repository at this point in the history

  9. black refactor

    @yahya-mouman
    yahya-mouman committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    5c10196 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Update releasenotes/notes/feat-llmobs-submit-langchain-embedding-span… 

    …s-89c8704ef41cfee3.yaml

Co-authored-by: Yun Kim <[email protected]>
    @yahya-mouman @Yun-Kim
    yahya-mouman and Yun-Kim authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    07645c0 View commit details
    Browse the repository at this point in the history

  2. remove chunk size

    @yahya-mouman
    yahya-mouman committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    0ce94ff View commit details
    Browse the repository at this point in the history

  3. Always output a documents list

    @yahya-mouman
    yahya-mouman committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    c21a95e View commit details
    Browse the repository at this point in the history

  4. Update tests and add langchain community tests

    @yahya-mouman
    yahya-mouman committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    ebe80c2 View commit details
    Browse the repository at this point in the history

  5. Add missing cassette for embedding documents

    @yahya-mouman
    yahya-mouman committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    f4ae74a View commit details
    Browse the repository at this point in the history

  6. Fix testing cases

    @yahya-mouman
    yahya-mouman committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    4a43d8a View commit details
    Browse the repository at this point in the history

  7. get first span in trace test

    @yahya-mouman
    yahya-mouman committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    bb0d168 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. lint checks fix

    @yahya-mouman
    yahya-mouman committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f5fcee0 View commit details
    Browse the repository at this point in the history

  2. add check for trace being a span

    @yahya-mouman
    yahya-mouman committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    2c931ae View commit details
    Browse the repository at this point in the history

  3. remove unnecessarily large cassette file

    @yahya-mouman
    yahya-mouman committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b008a76 View commit details
    Browse the repository at this point in the history

  4. remove unnecessarily large cassette file

    @yahya-mouman
    yahya-mouman committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    c0e0bc4 View commit details
    Browse the repository at this point in the history

  5. Use fake embedding in testing and fix count issue

    @yahya-mouman
    yahya-mouman committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    2ad9862 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Switch to cassette use for the query test

    @yahya-mouman
    yahya-mouman committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    31b42e3 View commit details
    Browse the repository at this point in the history

  2. black format

    @yahya-mouman
    yahya-mouman committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    a0605e1 View commit details
    Browse the repository at this point in the history

  3. hatch lint fix

    @yahya-mouman
    yahya-mouman committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    e7e0bb1 View commit details
    Browse the repository at this point in the history

  4. use openai embeddings

    @yahya-mouman
    yahya-mouman committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    512a60b View commit details
    Browse the repository at this point in the history

  5. use openai embeddings

    @yahya-mouman
    yahya-mouman committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    b2465eb View commit details
    Browse the repository at this point in the history

  6. switch from langchain_community to langchain_openai as it's a common … 

    …interface
    @yahya-mouman
    yahya-mouman committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    efe493f View commit details
    Browse the repository at this point in the history

  7. rename tests

    @yahya-mouman
    yahya-mouman committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    391eaa6 View commit details
    Browse the repository at this point in the history

  8. rename tests

    @yahya-mouman
    yahya-mouman committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    8a825d2 View commit details
    Browse the repository at this point in the history

  9. rename tests

    @yahya-mouman
    yahya-mouman committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    a571ec2 View commit details
    Browse the repository at this point in the history

  10. add tests to check workflow vs embedding behaviour

    @yahya-mouman
    yahya-mouman committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    8f9a39e View commit details
    Browse the repository at this point in the history

  11. Update tests/contrib/langchain/test_langchain_llmobs.py 

    Co-authored-by: Yun Kim <[email protected]>
    @yahya-mouman @Yun-Kim
    yahya-mouman and Yun-Kim authored Jul 24, 2024
    Configuration menu
    Copy the full SHA
    ae37dc9 View commit details
    Browse the repository at this point in the history

  12. black .

    @yahya-mouman
    yahya-mouman committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    cc80f9f View commit details
    Browse the repository at this point in the history

  13. fix name of test

    @yahya-mouman
    yahya-mouman committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    52448cf View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Update test_langchain_llmobs.py 

    Co-authored-by: Yun Kim <[email protected]>
    @yahya-mouman @Yun-Kim
    yahya-mouman and Yun-Kim authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    a3b7e83 View commit details
    Browse the repository at this point in the history

  2. fi linting

    @yahya-mouman
    yahya-mouman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    8b373a6 View commit details
    Browse the repository at this point in the history

  3. Test only workflow if openai is enabled

    @yahya-mouman
    yahya-mouman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    5293914 View commit details
    Browse the repository at this point in the history

  4. mcok get len safe embeddings

    @yahya-mouman
    yahya-mouman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    35e0439 View commit details
    Browse the repository at this point in the history

  5. mock get len safe embeddings

    @yahya-mouman
    yahya-mouman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    1c7e14e View commit details
    Browse the repository at this point in the history

  6. mock get len safe embeddings

    @yahya-mouman
    yahya-mouman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    bed1231 View commit details
    Browse the repository at this point in the history

  7. undo mock len safe embeddings

    @yahya-mouman
    yahya-mouman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    84b1977 View commit details
    Browse the repository at this point in the history

  8. correctly mock get len safe embeddings

    @yahya-mouman
    yahya-mouman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    6152655 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into yahya/add-langchain-embedding-support

    @yahya-mouman
    yahya-mouman authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    d4cf65a View commit details
    Browse the repository at this point in the history

  10. Update tests/contrib/langchain/test_langchain_llmobs.py 

    Co-authored-by: Yun Kim <[email protected]>
    @yahya-mouman @Yun-Kim
    yahya-mouman and Yun-Kim authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    40e8550 View commit details
    Browse the repository at this point in the history

  11. fix lint

    @yahya-mouman
    yahya-mouman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    61e5b97 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'main' into yahya/add-langchain-embedding-support

    @Yun-Kim
    Yun-Kim authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    9e9bd2d View commit details
    Browse the repository at this point in the history

  13. rename tests

    @yahya-mouman
    yahya-mouman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    812fdd5 View commit details
    Browse the repository at this point in the history

  14. Merge remote-tracking branch 'origin/yahya/add-langchain-embedding-su… 

    …pport' into yahya/add-langchain-embedding-support
    @yahya-mouman
    yahya-mouman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    8ae31a8 View commit details
    Browse the repository at this point in the history

  15. fmt

    @Yun-Kim
    Yun-Kim committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    5d9efb8 View commit details
    Browse the repository at this point in the history

  16. tmp change - skip logic

    @Yun-Kim
    Yun-Kim committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    e32948b View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. black

    @yahya-mouman
    yahya-mouman committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    c9bd4c9 View commit details
    Browse the repository at this point in the history

  2. ruff check fix

    @yahya-mouman
    yahya-mouman committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    ff66fb0 View commit details
    Browse the repository at this point in the history

  3. Fix version skipping

    @Yun-Kim
    Yun-Kim committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    edffa8b View commit details
    Browse the repository at this point in the history

  4. Fix version skipping on langchain test files

    @Yun-Kim
    Yun-Kim committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    eb55f38 View commit details
    Browse the repository at this point in the history

  5. WIP: comment out skipif by langchain version

    @Yun-Kim
    Yun-Kim committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    51290bf View commit details
    Browse the repository at this point in the history

  6. TMP WIP comment out sys version_info skipifs

    @Yun-Kim
    Yun-Kim committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    790f5ea View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. Undo langchain version gating

    @Yun-Kim
    Yun-Kim committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    e5e5a9d View commit details
    Browse the repository at this point in the history

  2. Revert langchain version gating change

    @Yun-Kim
    Yun-Kim committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    af016f4 View commit details
    Browse the repository at this point in the history

  3. Revert tmp python version gating commenting

    @Yun-Kim
    Yun-Kim committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    37db243 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Merge branch 'main' into yahya/add-langchain-embedding-support

    @Yun-Kim
    Yun-Kim authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    23da90d View commit details
    Browse the repository at this point in the history

  2. Regenerate cassette for embedding llmobs test

    @Yun-Kim
    Yun-Kim committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    c714c41 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Update tests/contrib/langchain/test_langchain_llmobs.py 

    Co-authored-by: Yun Kim <[email protected]>
    @yahya-mouman @Yun-Kim
    yahya-mouman and Yun-Kim authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    1737d04 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into yahya/add-langchain-embedding-support

    @yahya-mouman
    yahya-mouman authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    ac6ae33 View commit details
    Browse the repository at this point in the history

  3. use 3.9 cassettes when available

    @yahya-mouman
    yahya-mouman committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    b90842e View commit details
    Browse the repository at this point in the history

  4. use input_tag_key

    @yahya-mouman
    yahya-mouman committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    4858bb4 View commit details
    Browse the repository at this point in the history

  5. remove agentless = true

    @yahya-mouman
    yahya-mouman committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    1601844 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into yahya/add-langchain-embedding-support

    @yahya-mouman
    yahya-mouman authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    7f8cf92 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into yahya/add-langchain-embedding-support

    @Yun-Kim
    Yun-Kim authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    f99388d View commit details
    Browse the repository at this point in the history