Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iast): add local debug scripts to find segmentation faults #9395

Merged
merged 5 commits into from
May 28, 2024

Conversation

avara1986
Copy link
Member

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@avara1986 avara1986 requested review from a team as code owners May 27, 2024 14:43
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented May 27, 2024

Datadog Report

Branch report: avara1986/update_iast_debug_readme
Commit report: 63ffc0b
Test service: dd-trace-py

✅ 0 Failed, 138933 Passed, 38803 Skipped, 6h 26m 46.24s Total duration (3h 46m 9.65s time saved)
❄️ 1 New Flaky

New Flaky Tests (1)

  • test_send_failing_request[400] - test_writer.py - Last Failure

    Expand for error
     expected call not found.
     Expected: debug('failed to send telemetry to the %s at %s. response: %s', 'Datadog Agent', 'http://localhost:9126/telemetry/proxy/api/v2/apmtelemetry', 400)
     Actual: debug('sent %d in %.5fs to %s. response: %s', 803, 0.001671627999996872, 'http://localhost:9126/telemetry/proxy/api/v2/apmtelemetry', 200)
    

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.25%. Comparing base (be9936b) to head (63ffc0b).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9395       +/-   ##
===========================================
- Coverage   75.95%   10.25%   -65.71%     
===========================================
  Files        1297     1267       -30     
  Lines      123364   121518     -1846     
===========================================
- Hits        93700    12458    -81242     
- Misses      29664   109060    +79396     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avara1986 avara1986 enabled auto-merge (squash) May 28, 2024 06:47
@avara1986 avara1986 added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels May 28, 2024
@avara1986 avara1986 merged commit 44f7a82 into main May 28, 2024
88 checks passed
@avara1986 avara1986 deleted the avara1986/update_iast_debug_readme branch May 28, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants