Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): fix traceback max size for exceptions [backport 2.7] #9389

Merged
merged 2 commits into from
May 28, 2024

Commits on May 24, 2024

  1. fix(tracing): fix traceback max size for exceptions (#9112)

    #7558 made the traceback size
    configurable via `DD_SPAN_TRACEBACK_MAX_SIZE`, but tracebacks for
    exceptions were still hardcoded with a limit of 30.
    
    The fix is modeled after `Span#set_traceback`'s existing logic, and
    tests were modeled after both `test_traceback_with_error` and
    `test_custom_traceback_size`. Not much new logic, just an edge case.
    
    ## Checklist
    
    - [x] Change(s) are motivated and described in the PR description
    - [x] Testing strategy is described if automated tests are not included
    in the PR
    - [x] Risks are described (performance impact, potential for breakage,
    maintainability)
    - [x] Change is maintainable (easy to change, telemetry, documentation)
    - [x] [Library release note
    guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
    are followed or label `changelog/no-changelog` is set
    - [x] Documentation is included (in-code, generated user docs, [public
    corp docs](https://github.com/DataDog/documentation/))
    - [x] Backport labels are set (if
    [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
    - [x] If this PR changes the public interface, I've notified
    `@DataDog/apm-tees`.
    
    ## Reviewer Checklist
    
    - [x] Title is accurate
    - [x] All changes are related to the pull request's stated goal
    - [x] Description motivates each change
    - [x] Avoids breaking
    [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
    changes
    - [x] Testing strategy adequately addresses listed risks
    - [x] Change is maintainable (easy to change, telemetry, documentation)
    - [x] Release note makes sense to a user of the library
    - [x] Author has acknowledged and discussed the performance implications
    of this PR as reported in the benchmarks PR comment
    - [x] Backport labels are set in a manner that is consistent with the
    [release branch maintenance
    policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
    
    Co-authored-by: erikayasuda <[email protected]>
    (cherry picked from commit 1b954de)
    quiqueg authored and github-actions[bot] committed May 24, 2024
    Configuration menu
    Copy the full SHA
    ec338ea View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Configuration menu
    Copy the full SHA
    f6aef76 View commit details
    Browse the repository at this point in the history