chore(asm): avoid double calls on some aspect front-ends

[juanjux]

Description

Some aspects (index, slice, ljust, format, encode, decode and replace) were calling the original function and then potentially the native aspect, which would call again the original function. This reworks these aspect front-ends so only one call is ever done, which should improve performance a little.

This refactor also arised and error where we were not checking the CPython error with the new has_pyerror() helper in the native api_aspect_index so it fixed that too.

Checklist

• Change(s) are motivated and described in the PR description
• Testing strategy is described if automated tests are not included in the PR
• Risks are described (performance impact, potential for breakage, maintainability)
• Change is maintainable (easy to change, telemetry, documentation)
• Library release note guidelines are followed or label changelog/no-changelog is set
• Documentation is included (in-code, generated user docs, public corp docs)
• Backport labels are set (if applicable)
• If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

• Title is accurate
• All changes are related to the pull request's stated goal
• Description motivates each change
• Avoids breaking API changes
• Testing strategy adequately addresses listed risks
• Change is maintainable (easy to change, telemetry, documentation)
• Release note makes sense to a user of the library
• Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
• Backport labels are set in a manner that is consistent with the release branch maintenance policy

[datadog-dd-trace-py-rkomorn]

Datadog Report

Branch report: juanjux/APPSEC-53255-avoid-double-calls
Commit report: 3d05c3e
Test service: dd-trace-py

✅ 0 Failed, 109746 Passed, 3758 Skipped, 6m 25.39s Total duration (41m 56.16s time saved)

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-05-22 12:02:47

Comparing candidate commit 2010dbf in PR branch juanjux/APPSEC-53255-avoid-double-calls with baseline commit 66b96e9 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 209 metrics, 9 unstable metrics.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 14.49275% with 59 lines in your changes are missing coverage. Please review.

Project coverage is 10.25%. Comparing base (66b96e9) to head (3d05c3e).
Report is 8 commits behind head on main.

Files	Patch %	Lines
ddtrace/appsec/_iast/_taint_tracking/aspects.py	22.22%	35 Missing ⚠️
...s/appsec/iast/aspects/test_encode_decode_aspect.py	0.00%	18 Missing ⚠️
.../appsec/iast/aspects/test_index_aspect_fixtures.py	0.00%	3 Missing ⚠️
tests/appsec/iast/aspects/test_str_aspect.py	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #9344       +/-   ##
===========================================
- Coverage   76.02%   10.25%   -65.77%     
===========================================
  Files        1294     1266       -28     
  Lines      122816   121219     -1597     
===========================================
- Hits        93370    12437    -80933     
- Misses      29446   108782    +79336     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.