Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(botocore): abstract away propagation header extraction code #9087

Merged
merged 45 commits into from
May 1, 2024

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Apr 24, 2024

This change adds a layer of abstraction between the botocore integration and the extraction of distributed tracing information from request data by using the Core API, increasing the separation of concerns between instrumentation and products.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler requested review from a team as code owners April 24, 2024 19:09
@pr-commenter
Copy link

pr-commenter bot commented Apr 24, 2024

Benchmarks

Benchmark execution time: 2024-04-30 19:32:06

Comparing candidate commit 6fc0f19 in PR branch emmett.butler/remove-propagate-calls with baseline commit c46f79b in branch main.

Found 1 performance improvements and 7 performance regressions! Performance is the same for 201 metrics, 9 unstable metrics.

scenario:otelspan-start-finish

  • 🟩 max_rss_usage [-782.353KB; -704.495KB] or [-3.473%; -3.127%]

scenario:sethttpmeta-no-collectipvariant

  • 🟥 max_rss_usage [+701.261KB; +773.709KB] or [+3.358%; +3.704%]

scenario:sethttpmeta-obfuscation-no-query

  • 🟥 max_rss_usage [+744.515KB; +811.146KB] or [+3.568%; +3.887%]

scenario:sethttpmeta-obfuscation-send-querystring-disabled

  • 🟥 max_rss_usage [+745.764KB; +822.594KB] or [+3.534%; +3.898%]

scenario:sethttpmeta-obfuscation-worst-case-implicit-query

  • 🟥 max_rss_usage [+725.449KB; +807.274KB] or [+3.439%; +3.827%]

scenario:sethttpmeta-useragentvariant_not_exists_1

  • 🟥 max_rss_usage [+721.449KB; +793.662KB] or [+3.454%; +3.800%]

scenario:tracer-large

  • 🟥 max_rss_usage [+712.050KB; +790.772KB] or [+3.278%; +3.641%]

scenario:tracer-small

  • 🟥 max_rss_usage [+684.745KB; +772.202KB] or [+3.319%; +3.743%]

Base automatically changed from emmett.butler/deduplicate-util-fn to main April 25, 2024 13:37
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 2.46914% with 79 lines in your changes are missing coverage. Please review.

Project coverage is 6.59%. Comparing base (97af079) to head (13240e7).
Report is 2 commits behind head on main.

Files Patch % Lines
ddtrace/_trace/utils.py 0.00% 29 Missing ⚠️
ddtrace/_trace/trace_handlers.py 8.33% 22 Missing ⚠️
ddtrace/contrib/botocore/services/sqs.py 0.00% 8 Missing ⚠️
ddtrace/contrib/botocore/utils.py 0.00% 8 Missing ⚠️
ddtrace/contrib/botocore/patch.py 0.00% 5 Missing ⚠️
ddtrace/contrib/botocore/services/kinesis.py 0.00% 5 Missing ⚠️
ddtrace/internal/datastreams/botocore.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9087       +/-   ##
===========================================
- Coverage   78.48%    6.59%   -71.90%     
===========================================
  Files        1271     1241       -30     
  Lines      119684   118072     -1612     
===========================================
- Hits        93934     7784    -86150     
- Misses      25750   110288    +84538     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmettbutler emmettbutler requested a review from a team as a code owner April 29, 2024 20:09
@emmettbutler emmettbutler enabled auto-merge (squash) April 30, 2024 17:42
@emmettbutler emmettbutler merged commit c8b907b into main May 1, 2024
152 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/remove-propagate-calls branch May 1, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants