-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(botocore): abstract away propagation header extraction code #9087
Conversation
BenchmarksBenchmark execution time: 2024-04-30 19:32:06 Comparing candidate commit 6fc0f19 in PR branch Found 1 performance improvements and 7 performance regressions! Performance is the same for 201 metrics, 9 unstable metrics. scenario:otelspan-start-finish
scenario:sethttpmeta-no-collectipvariant
scenario:sethttpmeta-obfuscation-no-query
scenario:sethttpmeta-obfuscation-send-querystring-disabled
scenario:sethttpmeta-obfuscation-worst-case-implicit-query
scenario:sethttpmeta-useragentvariant_not_exists_1
scenario:tracer-large
scenario:tracer-small
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9087 +/- ##
===========================================
- Coverage 78.48% 6.59% -71.90%
===========================================
Files 1271 1241 -30
Lines 119684 118072 -1612
===========================================
- Hits 93934 7784 -86150
- Misses 25750 110288 +84538 ☔ View full report in Codecov by Sentry. |
This change adds a layer of abstraction between the botocore integration and the extraction of distributed tracing information from request data by using the Core API, increasing the separation of concerns between instrumentation and products.
Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.Reviewer Checklist