Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): update pytest 3.x dependencies for celery and flask_cache to 4.x #8974

Merged

Conversation

romainkomorndatadog
Copy link
Collaborator

@romainkomorndatadog romainkomorndatadog commented Apr 15, 2024

This bumps pytest dependencies pinned on 3.10.1 (which is from late 2018) to ~=4.0 which should install 4.6.11 which dates back to mid-2020.

It also bumps pytest-cov to ~=3.0 due to some functions having been removed in 2.x that we need for the coverage integration.

I'm using ~= for specifying versions even though the versions being used are old enough that they're no longer getting updates, so this effectively a version pin. I don't think that really matters, though, and I think in general our riotfile.py probably benefits from using compatible release clauses.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@romainkomorndatadog romainkomorndatadog self-assigned this Apr 15, 2024
@romainkomorndatadog romainkomorndatadog added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 15, 2024
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Apr 15, 2024

Datadog Report

Branch report: romain.komorn/CIVIS-9428/drop_old_pytest_envs
Commit report: 55aa862
Test service: dd-trace-py

✅ 0 Failed, 172043 Passed, 1080 Skipped, 12h 8m 1.86s Total duration (39m 12.31s time saved)

@romainkomorndatadog romainkomorndatadog marked this pull request as ready for review April 15, 2024 10:52
@romainkomorndatadog romainkomorndatadog requested review from avara1986, ZStriker19, erikayasuda, P403n1x87, a team and jbertran and removed request for a team April 15, 2024 10:52
@romainkomorndatadog
Copy link
Collaborator Author

This unblocks #8727 .

@pr-commenter
Copy link

pr-commenter bot commented Apr 15, 2024

Benchmarks

Benchmark execution time: 2024-04-15 11:33:01

Comparing candidate commit 55aa862 in PR branch romain.komorn/CIVIS-9428/drop_old_pytest_envs with baseline commit ee960a0 in branch main.

Found 7 performance improvements and 3 performance regressions! Performance is the same for 191 metrics, 9 unstable metrics.

scenario:flasksimple-appsec-telemetry

  • 🟥 execution_time [+165.223µs; +225.770µs] or [+2.635%; +3.600%]

scenario:httppropagationextract-datadog_tracecontext_tracestate_not_propagated_on_trace_id_no_match

  • 🟥 max_rss_usage [+701.263KB; +769.201KB] or [+3.314%; +3.635%]

scenario:httppropagationextract-wsgi_invalid_trace_id_header

  • 🟥 max_rss_usage [+783.359KB; +929.589KB] or [+3.724%; +4.419%]

scenario:httppropagationinject-ids_only

  • 🟩 max_rss_usage [-768.258KB; -714.494KB] or [-3.516%; -3.270%]

scenario:httppropagationinject-with_dd_origin

  • 🟩 max_rss_usage [-1.083MB; -1.026MB] or [-4.958%; -4.697%]

scenario:httppropagationinject-with_sampling_priority

  • 🟩 max_rss_usage [-740.793KB; -690.350KB] or [-3.392%; -3.161%]

scenario:httppropagationinject-with_tags

  • 🟩 max_rss_usage [-643.474KB; -584.916KB] or [-2.942%; -2.675%]

scenario:httppropagationinject-with_tags_invalid

  • 🟩 max_rss_usage [-630.540KB; -574.503KB] or [-2.884%; -2.627%]

scenario:httppropagationinject-with_tags_max_size

  • 🟩 max_rss_usage [-655.090KB; -607.297KB] or [-2.994%; -2.776%]

scenario:span-start-finish

  • 🟩 max_rss_usage [-803.680KB; -734.368KB] or [-3.654%; -3.339%]

@romainkomorndatadog romainkomorndatadog enabled auto-merge (squash) April 17, 2024 13:18
@romainkomorndatadog romainkomorndatadog merged commit d1b276f into main Apr 17, 2024
145 checks passed
@romainkomorndatadog romainkomorndatadog deleted the romain.komorn/CIVIS-9428/drop_old_pytest_envs branch April 17, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants