Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(botocore): abstract integration from products in patch entrypoint #8901

Merged
merged 10 commits into from
Apr 15, 2024

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Apr 8, 2024

This pull request removes mentions of Spans and Tracing from the main botocore patching entrypoint, increasing the separation of concerns between the integration and Products. There are also some refactors aimed at deduplicating code to make it easier to abstract in this way.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler requested review from a team as code owners April 8, 2024 18:37
@emmettbutler emmettbutler marked this pull request as draft April 8, 2024 18:37
@emmettbutler emmettbutler changed the title start work on separating botocore integration from products chore(botocore): abstract integration from products Apr 8, 2024
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Apr 8, 2024

Datadog Report

Branch report: emmett.butler/botocore-abstraction
Commit report: 7ae8b4c
Test service: dd-trace-py

✅ 0 Failed, 10680 Passed, 158430 Skipped, 3h 54m 7.64s Total duration (5h 38m 13.37s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Apr 8, 2024

Benchmarks

Benchmark execution time: 2024-04-15 16:38:30

Comparing candidate commit 103fb10 in PR branch emmett.butler/botocore-abstraction with baseline commit 8c93d68 in branch main.

Found 2 performance improvements and 1 performance regressions! Performance is the same for 182 metrics, 9 unstable metrics.

scenario:httppropagationextract-invalid_priority_header

  • 🟥 max_rss_usage [+435.024KB; +710.217KB] or [+2.077%; +3.392%]

scenario:httppropagationextract-none_propagation_style

  • 🟩 max_rss_usage [-647.870KB; -453.545KB] or [-2.965%; -2.075%]

scenario:httppropagationextract-wsgi_empty_headers

  • 🟩 max_rss_usage [-648.620KB; -460.577KB] or [-2.966%; -2.106%]

@emmettbutler emmettbutler changed the title chore(botocore): abstract integration from products chore(botocore): abstract integration from products in patch entrypoint Apr 9, 2024
@emmettbutler emmettbutler marked this pull request as ready for review April 9, 2024 18:45
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question about the stepfunctions change, otherwise lgtm

ddtrace/contrib/botocore/services/stepfunctions.py Outdated Show resolved Hide resolved
@emmettbutler emmettbutler enabled auto-merge (squash) April 15, 2024 19:36
@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 15, 2024
@emmettbutler emmettbutler merged commit 051d077 into main Apr 15, 2024
155 of 157 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/botocore-abstraction branch April 15, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants