-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(botocore): abstract integration from products in patch entrypoint #8901
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 10680 Passed, 158430 Skipped, 3h 54m 7.64s Total duration (5h 38m 13.37s time saved) |
BenchmarksBenchmark execution time: 2024-04-15 16:38:30 Comparing candidate commit 103fb10 in PR branch Found 2 performance improvements and 1 performance regressions! Performance is the same for 182 metrics, 9 unstable metrics. scenario:httppropagationextract-invalid_priority_header
scenario:httppropagationextract-none_propagation_style
scenario:httppropagationextract-wsgi_empty_headers
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question about the stepfunctions change, otherwise lgtm
This pull request removes mentions of Spans and Tracing from the main botocore patching entrypoint, increasing the separation of concerns between the integration and Products. There are also some refactors aimed at deduplicating code to make it easier to abstract in this way.
Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.Reviewer Checklist