chore(ci suitespec): default to diffing against base branch if exactly 30 changed files returned #6649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of test commit c5c7d0a.
We currently use the Github REST API to see all changed files in a PR, and default to using a
git diff
against a base commit if that fails. However, the REST API call will return at most 30 changed files which are used to compute which test suites to run, so large PRs (potentially with many lockfiles changed) will potentially not trigger test suites.This PR adds a workaround where if we get exactly 30 changed files in the Github REST call, we will default to using
git diff
instead. The only risk is PRs with exactly 30 changed files, but usinggit diff
should not significantly change any result.Checklist
changelog/no-changelog
.Reviewer Checklist