Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix subprocess wrapper [backport 1.18] #6646

Merged
merged 2 commits into from
Aug 12, 2023
Merged

Conversation

github-actions[bot]
Copy link
Contributor

Backport 8863df6 from #6624 to 1.18.

This change fixes the pytest.mark.subprocess decorator

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed. If no release note is required, add label changelog/no-changelog.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

This change fixes the `pytest.mark.subprocess` decorator

## Checklist
- [x] Change(s) are motivated and described in the PR description.
- [x] Testing strategy is described if automated tests are not included
in the PR.
- [x] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed. If no release note is required, add label
`changelog/no-changelog`.
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist

- [x] Title is accurate.
- [x] No unnecessary changes are introduced.
- [x] Description motivates each change.
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [x] Testing strategy adequately addresses listed risk(s).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] Release note makes sense to a user of the library.
- [x] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Co-authored-by: Gabriele N. Tornetta <[email protected]>
(cherry picked from commit 8863df6)
@github-actions github-actions bot requested review from a team as code owners August 11, 2023 13:45
@github-actions github-actions bot added changelog/no-changelog A changelog entry is not required for this PR. CI labels Aug 11, 2023
@pr-commenter
Copy link

pr-commenter bot commented Aug 11, 2023

Benchmarks

Benchmark execution time: 2023-08-11 22:18:19

Comparing candidate commit 1a571b7 in PR branch backport-6624-to-1.18 with baseline commit cc8d9dc in branch 1.18.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 94 metrics, 0 unstable metrics.

@P403n1x87 P403n1x87 closed this Aug 11, 2023
@P403n1x87 P403n1x87 reopened this Aug 11, 2023
@P403n1x87 P403n1x87 enabled auto-merge (squash) August 11, 2023 21:31
@P403n1x87 P403n1x87 merged commit a176097 into 1.18 Aug 12, 2023
24 checks passed
@P403n1x87 P403n1x87 deleted the backport-6624-to-1.18 branch August 12, 2023 04:54
@github-actions github-actions bot added this to the v1.18.1 milestone Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants