Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(profiling): unset DD_SITE variable in agentless URL check [backport 1.17] #6644

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Backport edac03b from #6642 to 1.17.

A test for the profiler exporter in agentless mode required the DD_SITE variable to be unset. We modify the test to ensure that this variable is unset in the subprocess to exercise and test the correct logic.

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed. If no release note is required, add label changelog/no-changelog.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

A test for the profiler exporter in agentless mode required the DD_SITE
variable to be unset. We modify the test to ensure that this variable is
unset in the subprocess to exercise and test the correct logic.

## Checklist

- [x] Change(s) are motivated and described in the PR description.
- [x] Testing strategy is described if automated tests are not included
in the PR.
- [x] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed. If no release note is required, add label
`changelog/no-changelog`.
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist

- [x] Title is accurate.
- [x] No unnecessary changes are introduced.
- [x] Description motivates each change.
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [x] Testing strategy adequately addresses listed risk(s).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] Release note makes sense to a user of the library.
- [x] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit edac03b)
@github-actions github-actions bot requested review from a team as code owners August 11, 2023 12:26
@github-actions github-actions bot added changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling labels Aug 11, 2023
@P403n1x87 P403n1x87 closed this Aug 11, 2023
@P403n1x87 P403n1x87 reopened this Aug 11, 2023
@majorgreys majorgreys enabled auto-merge (squash) August 11, 2023 13:08
@pr-commenter
Copy link

pr-commenter bot commented Aug 11, 2023

Benchmarks

Benchmark execution time: 2023-08-11 16:59:38

Comparing candidate commit 3931401 in PR branch backport-6642-to-1.17 with baseline commit ff8ab1c in branch 1.17.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 94 metrics, 0 unstable metrics.

@majorgreys majorgreys merged commit 59a0820 into 1.17 Aug 11, 2023
24 checks passed
@majorgreys majorgreys deleted the backport-6642-to-1.17 branch August 11, 2023 17:07
@github-actions github-actions bot added this to the v1.17.4 milestone Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants