Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(framework tests): skip failing sanic test [backport #6539 to 1.17] #6628

Merged
merged 4 commits into from
Aug 18, 2023

Commits on Aug 10, 2023

  1. chore(framework tests): skip failing sanic test (#6539)

    The sanic framework tests have recently started failing a single test:
    `test_redirect_with_params`, which has a weird error relating to string
    formatting: `"sanic%20test" != "sanic test"`.
    This test's assertion was subtly changed in the most recent release of
    sanic by altering the string formatting of the asserted string value,
    and this only started failing once the new version of sanic (23.3.0) was
    released, so we can consider skipping this test for now until we upgrade
    to match the latest version of sanic.
    
    - [x] Change(s) are motivated and described in the PR description.
    - [x] Testing strategy is described if automated tests are not included
    in the PR.
    - [x] Risk is outlined (performance impact, potential for breakage,
    maintainability, etc).
    - [x] Change is maintainable (easy to change, telemetry, documentation).
    - [x] [Library release note
    guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
    are followed. If no release note is required, add label
    `changelog/no-changelog`.
    - [x] Documentation is included (in-code, generated user docs, [public
    corp docs](https://github.com/DataDog/documentation/)).
    - [x] Backport labels are set (if
    [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
    
    - [ ] Title is accurate.
    - [ ] No unnecessary changes are introduced.
    - [ ] Description motivates each change.
    - [ ] Avoids breaking
    [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
    changes unless absolutely necessary.
    - [ ] Testing strategy adequately addresses listed risk(s).
    - [ ] Change is maintainable (easy to change, telemetry, documentation).
    - [ ] Release note makes sense to a user of the library.
    - [ ] Reviewer has explicitly acknowledged and discussed the performance
    implications of this PR as reported in the benchmarks PR comment.
    - [ ] Backport labels are set in a manner that is consistent with the
    [release branch maintenance
    policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
    
    (cherry picked from commit d06ec2f)
    Yun-Kim authored and P403n1x87 committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    803c123 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Configuration menu
    Copy the full SHA
    3be0be5 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Configuration menu
    Copy the full SHA
    6522689 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Configuration menu
    Copy the full SHA
    71a981e View commit details
    Browse the repository at this point in the history