Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [SVLS-5265] add span links to encoded spans #10850

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

apiarian-datadog
Copy link
Contributor

@apiarian-datadog apiarian-datadog commented Sep 27, 2024

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Sep 27, 2024

CODEOWNERS have been resolved as:

ddtrace/internal/encoding.py                                            @DataDog/apm-core-python
tests/integration/test_encoding.py                                      @DataDog/apm-core-python
tests/tracer/test_encoders.py                                           @DataDog/apm-sdk-api-python

@apiarian-datadog
Copy link
Contributor Author

followup from DataDog/datadog-lambda-python#513 where we are using the logwriter output and missing the span links for our integration tests.

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Sep 27, 2024

Datadog Report

Branch report: aleksandr.pasechnik/svls-5265-span-links-serialized-logwriter
Commit report: 71d512b
Test service: dd-trace-py

✅ 0 Failed, 1129 Passed, 157 Skipped, 26m 42.18s Total duration (9m 41s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Sep 27, 2024

Benchmarks

Benchmark execution time: 2024-10-08 18:23:59

Comparing candidate commit 71d512b in PR branch aleksandr.pasechnik/svls-5265-span-links-serialized-logwriter with baseline commit cd1753d in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 371 metrics, 53 unstable metrics.

@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-5265-span-links-serialized-logwriter branch 3 times, most recently from 1eb154c to 4ec5be1 Compare October 4, 2024 14:42
@apiarian-datadog apiarian-datadog added the changelog/no-changelog A changelog entry is not required for this PR. label Oct 4, 2024
@apiarian-datadog apiarian-datadog marked this pull request as ready for review October 7, 2024 14:23
@apiarian-datadog apiarian-datadog requested review from a team as code owners October 7, 2024 14:23
@ZStriker19 ZStriker19 self-requested a review October 7, 2024 14:27
@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-5265-span-links-serialized-logwriter branch from 36f643e to 71d512b Compare October 8, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants