Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(profiling): venvs to test profiler v2 #10538

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Sep 5, 2024

  • Created venvs with name profile-v2, it only runs tests in tests/profiling-v2 with environment variable DD_PROFILING_EXPORT_LIBDD_ENABLED set. We plan to add DD_PROFILING_STACK_V2_ENABLED soon.
  • Updated gitlab to run for profile$|profile-v2
  • Moved some tests to tests/profiling-v2

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

PROF-10349

@taegyunkim taegyunkim requested review from a team as code owners September 5, 2024 19:54
@taegyunkim taegyunkim added the Profiling Continous Profling label Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

CODEOWNERS have been resolved as:

.riot/requirements/11f3e97.txt                                          @DataDog/apm-python
.riot/requirements/131588c.txt                                          @DataDog/apm-python
.riot/requirements/14135e2.txt                                          @DataDog/apm-python
.riot/requirements/146c75e.txt                                          @DataDog/apm-python
.riot/requirements/14aae80.txt                                          @DataDog/apm-python
.riot/requirements/14c79d8.txt                                          @DataDog/apm-python
.riot/requirements/15103d9.txt                                          @DataDog/apm-python
.riot/requirements/16795af.txt                                          @DataDog/apm-python
.riot/requirements/1812397.txt                                          @DataDog/apm-python
.riot/requirements/1a66299.txt                                          @DataDog/apm-python
.riot/requirements/1f31244.txt                                          @DataDog/apm-python
.riot/requirements/3725aba.txt                                          @DataDog/apm-python
.riot/requirements/4b27be0.txt                                          @DataDog/apm-python
.riot/requirements/4ee9c38.txt                                          @DataDog/apm-python
.riot/requirements/5965bcc.txt                                          @DataDog/apm-python
.riot/requirements/7c55cd2.txt                                          @DataDog/apm-python
.riot/requirements/908fc42.txt                                          @DataDog/apm-python
.riot/requirements/aef0d14.txt                                          @DataDog/apm-python
.riot/requirements/c6a8c83.txt                                          @DataDog/apm-python
.riot/requirements/f16d548.txt                                          @DataDog/apm-python
tests/profiling-v2/__init__.py                                          @DataDog/profiling-python
tests/profiling-v2/exporter/__init__.py                                 @DataDog/profiling-python
.github/CODEOWNERS                                                      @DataDog/python-guild @DataDog/apm-core-python
.gitlab/tests/profiling.yml                                             @DataDog/profiling-python
riotfile.py                                                             @DataDog/apm-python
tests/.suitespec.json                                                   @DataDog/python-guild @DataDog/apm-core-python
tests/profiling/test_profiler.py                                        @DataDog/profiling-python
tests/profiling-v2/exporter/test_ddup.py                                @DataDog/profiling-python

@taegyunkim taegyunkim requested review from a team as code owners September 5, 2024 20:28
@taegyunkim taegyunkim added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 5, 2024
Copy link
Contributor Author

taegyunkim commented Sep 5, 2024

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Sep 5, 2024

Datadog Report

Branch report: taegyunkim/prof-10349-venvs
Commit report: fd6dbd8
Test service: dd-trace-py

✅ 0 Failed, 20671 Passed, 1985 Skipped, 2h 45m 44.8s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Sep 5, 2024

Benchmarks

Benchmark execution time: 2024-09-05 21:49:04

Comparing candidate commit fd6dbd8 in PR branch taegyunkim/prof-10349-venvs with baseline commit c6c48b0 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 354 metrics, 46 unstable metrics.

Copy link
Contributor

@sanchda sanchda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this is the right way to go. In particular, if we don't follow this strategy, then we'll need to compartmentalize individual tests in their own subprocesses, which will make it harder to deduce global state issues we don't explicitly test for. Plus this way we can write the test in a way that is more similar to how an end-user application will be instrumented.

@taegyunkim taegyunkim merged commit 483a625 into main Sep 6, 2024
412 of 414 checks passed
@taegyunkim taegyunkim deleted the taegyunkim/prof-10349-venvs branch September 6, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants