-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(profiling): venvs to test profiler v2 #10538
Conversation
|
74bb276
to
1a9bdb0
Compare
f5090b1
to
fd6dbd8
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @taegyunkim and the rest of your teammates on Graphite |
Datadog ReportBranch report: ✅ 0 Failed, 20671 Passed, 1985 Skipped, 2h 45m 44.8s Total Time |
BenchmarksBenchmark execution time: 2024-09-05 21:49:04 Comparing candidate commit fd6dbd8 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 354 metrics, 46 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think this is the right way to go. In particular, if we don't follow this strategy, then we'll need to compartmentalize individual tests in their own subprocesses, which will make it harder to deduce global state issues we don't explicitly test for. Plus this way we can write the test in a way that is more similar to how an end-user application will be instrumented.
profile-v2
, it only runs tests intests/profiling-v2
with environment variableDD_PROFILING_EXPORT_LIBDD_ENABLED
set. We plan to addDD_PROFILING_STACK_V2_ENABLED
soon.profile$|profile-v2
tests/profiling-v2
Checklist
Reviewer Checklist
PROF-10349