Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move flask suite to GitLab #10469

Merged
merged 15 commits into from
Sep 9, 2024
Merged

ci: move flask suite to GitLab #10469

merged 15 commits into from
Sep 9, 2024

Conversation

brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented Aug 31, 2024

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 31, 2024
@brettlangdon brettlangdon requested review from a team as code owners August 31, 2024 14:47
@brettlangdon
Copy link
Member Author

Waiting on mirroring of memcached image.

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Aug 31, 2024

Datadog Report

Branch report: brettlangdon/gitlab.flask
Commit report: 206bfb7
Test service: dd-trace-py

❌ 1 Failed (0 Known Flaky), 6979 Passed, 3092 Skipped, 1h 30m 47.8s Total duration (41m 46.86s time saved)

❌ Failed Tests (1)

  • test_cohere_embedding - test_bedrock.py - Details

    Expand for error
     At request <Request GET /test/session/snapshot >:
        At snapshot (token='tests.contrib.botocore.test_bedrock.test_cohere_embedding'):
         - Directory: /snapshots
         - CI mode: 0
         - Trace File: /snapshots/tests.contrib.botocore.test_bedrock.test_cohere_embedding.json
         - Stats File: /snapshots/tests.contrib.botocore.test_bedrock.test_cohere_embedding_tracestats.json
         At compare of 1 expected trace(s) to 0 received trace(s):
     Did not receive expected traces: 'bedrock-runtime.command'
    

Copy link
Contributor

github-actions bot commented Sep 2, 2024

CODEOWNERS have been resolved as:

.circleci/config.templ.yml                                              @DataDog/python-guild @DataDog/apm-core-python
.gitlab/services.yml                                                    @DataDog/python-guild @DataDog/apm-core-python
.gitlab/tests/contrib.yml                                               @DataDog/python-guild @DataDog/apm-core-python

@pr-commenter
Copy link

pr-commenter bot commented Sep 2, 2024

Benchmarks

Benchmark execution time: 2024-09-09 18:21:36

Comparing candidate commit 206bfb7 in PR branch brettlangdon/gitlab.flask with baseline commit 52cf1fe in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 218 metrics, 44 unstable metrics.

@brettlangdon brettlangdon requested a review from a team as a code owner September 3, 2024 17:25
brettlangdon and others added 8 commits September 3, 2024 17:54
circle ci is broken after #10487

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
@brettlangdon brettlangdon enabled auto-merge (squash) September 9, 2024 18:22
@brettlangdon brettlangdon merged commit 036f823 into main Sep 9, 2024
497 checks passed
@brettlangdon brettlangdon deleted the brettlangdon/gitlab.flask branch September 9, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants